Add more commands tests #500

yungwine · 2025-12-22T08:22:28Z

No description provided.

Copilot

Pull request overview

This PR adds comprehensive integration test coverage for command-line interface commands across wallet, validator, pool, backup, and BTC teleport modules. The tests use mocking extensively to isolate command behavior and verify correct interactions with core components.

Key changes:

Added 8 new test files covering wallet, validator, pool (single/nominator/general), backup, and BTC teleport commands
Improved test infrastructure with helper functions and fixture enhancements
Enhanced production code with type hints, better exception handling, and code cleanup
Updated CI workflow to test against Python 3.8-3.13 and added Ruff linting

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
tests/integration/test_wallet_commands.py	Tests for wallet operations (create, activate, list, import, export, delete, transfer)
tests/integration/test_validator_commands.py	Tests for validator operations (voting, efficiency checking, collator management)
tests/integration/test_single_pool_commands.py	Tests for single nominator pool commands (create, activate, withdraw)
tests/integration/test_pool_commands.py	Tests for general pool commands (list, delete, import)
tests/integration/test_nominator_pool_commands.py	Tests for nominator pool commands (create, activate, deposit, withdraw)
tests/integration/test_btc_teleport_commands.py	Tests for BTC teleport removal command
tests/integration/test_backup_commands.py	Tests for backup creation and restoration
tests/integration/test_basic_commands.py	Updated to use package resource path helper
tests/helpers.py	Added helper function for creating pool files in tests
tests/conftest.py	Modified CLI fixture setup with monkeypatching
setup.py	Excluded tests from package, bumped minimum Python to 3.8, removed Python 3.7 classifier
mytonctrl/utils.py	Added type hints, improved exception handling
mytonctrl/scripts/xrestart.py	Removed entire deprecated script
mytonctrl/scripts/etabar.py	Improved code style (None comparison)
mytonctrl/progressbar.py	Improved code style (boolean comparison)
mytonctrl/mytonctrl.py	Multiple improvements: removed unused imports/code, better exception handling, type hints, f-string fixes
mytoncore/mytoncore.py	Added type hints, removed Init() call from constructor
mytoncore/functions.py	Removed unused auto_vote_offers cycle
modules/btc_teleport.py	Removed unused offer voting methods, added type hints
modules/backups.py	Added type hints, improved error handling
.github/workflows/tests.yml	Added Python version matrix (3.8-3.13), Ruff linting, and build step

Comments suppressed due to low confidence (1)

tests/conftest.py:34

This comment appears to contain commented-out code.

    # def write_db(self, data):
    #     self.buffer.old_db = Dict(self.db)
    #
    # def load_db(self, db_path=False):
    #     self.set_default_config()
    #     return True

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-22T08:27:13Z

tests/integration/test_nominator_pool_commands.py

+    account.status = "empty"
+    with pytest.raises(Exception) as e:
+        cli.execute(f"activate_pool {pool_name}")
+    assert "account status is empty" in str(e)


The exception assertion is checking 'str(e)' which captures the ExceptionInfo object representation, not the actual exception message. It should be 'str(e.value)' to check the actual exception message.

Suggested change

assert "account status is empty" in str(e)

assert "account status is empty" in str(e.value)

Copilot · 2025-12-22T08:27:13Z

tests/integration/test_single_pool_commands.py

+    with pytest.raises(Exception) as e:
+        cli.execute(f"new_single_pool pool2 {owner_address}")
+    assert os.path.isfile(addr_file)
+    assert 'Pool with the same parameters already exists' in str(e)


The exception assertion is checking 'str(e)' which captures the ExceptionInfo object representation, not the actual exception message. It should be 'str(e.value)' to check the actual exception message.

Suggested change

assert 'Pool with the same parameters already exists' in str(e)

assert 'Pool with the same parameters already exists' in str(e.value)

Copilot · 2025-12-22T08:27:13Z

tests/conftest.py

+    # def write_db(self, data):
+    #     self.buffer.old_db = Dict(self.db)
+    #
+    # def load_db(self, db_path=False):
+    #     self.set_default_config()
+    #     return True


Commented-out code should be removed rather than left in the codebase. If these methods are no longer needed, they should be deleted entirely. If they might be needed in the future, consider documenting why they're disabled.

Copilot · 2025-12-22T08:27:14Z

modules/backups.py

+import typing
+from typing import Optional


The 'typing' module is imported on line 5, but Optional is imported from typing on line 6. The 'typing' import on line 5 should be removed since it's redundant - only the specific Optional type is needed.

Copilot · 2025-12-22T08:27:14Z

modules/backups.py

            return subprocess.run(["bash", backup_script_path, "-u", user] + args, timeout=5)

-    def create_backup(self, args):
+    def create_backup(self, args: list) -> typing.Union[int, None]:


The return type annotation 'typing.Union[int, None]' should be simplified to 'Optional[int]' for consistency with the rest of the codebase. The Optional type is already imported on line 6.

Suggested change

def create_backup(self, args: list) -> typing.Union[int, None]:

def create_backup(self, args: list) -> Optional[int]:

Copilot · 2025-12-22T08:27:16Z

tests/integration/test_nominator_pool_commands.py

+    with pytest.raises(Exception) as e:
+        cli.execute(f"new_pool pool2 5.5 10 10000 1000")
+    assert os.path.isfile(addr_file)
+    assert 'Pool with the same parameters already exists' in str(e)


The exception assertion is checking 'str(e)' which captures the ExceptionInfo object representation, not the actual exception message. It should be 'str(e.value)' to check the actual exception message.

Suggested change

assert 'Pool with the same parameters already exists' in str(e)

assert 'Pool with the same parameters already exists' in str(e.value)

Copilot · 2025-12-22T08:27:16Z

tests/integration/test_single_pool_commands.py

@@ -0,0 +1,131 @@
+import os
+import struct


Import of 'struct' is not used.

Suggested change

import struct

Copilot · 2025-12-22T08:27:16Z

tests/integration/test_single_pool_commands.py

+
+import pytest
+from pytest_mock import MockerFixture
+from mypylib import Dict


Import of 'Dict' is not used.

Suggested change

from mypylib import Dict

Copilot · 2025-12-22T08:27:17Z

tests/integration/test_single_pool_commands.py

+from pytest_mock import MockerFixture
+from mypylib import Dict
+from mytoncore.mytoncore import MyTonCore
+from modules.single_pool import SingleNominatorModule


Import of 'SingleNominatorModule' is not used.

Suggested change

from modules.single_pool import SingleNominatorModule

Copilot · 2025-12-22T08:27:17Z

mytonctrl/mytonctrl.py

+	except Exception:
+		pass


'except' clause does nothing but pass and there is no explanatory comment.

Suggested change

except Exception:

pass

except Exception as exc:

# Log the error but continue with ADNL connection check

local.add_log(f"Failed to get validator config for ADNL check: {exc}", "warning")

yungwine added 14 commits December 11, 2025 16:50

add backups integration tests

b9b91ab

add ruff linting to mytonctrl/

3629107

upd min python version to 3.8

03f2efa

add building project to workflow, test project as package

6454498

rm btc teleport offer functionality

72fa4e3

add btc teleport tests

d49b609

improve modules/backups code

ead3edd

add validator command tests

bd9882f

add wallet commands tests

03474aa

add pool commands tests

7bc2e9e

add nominator pool commands tests

8a952a5

add single nominator pool commands tests

3ba9486

fix cli fixture creation in tests

4f79bc3

rm memory warning from tests

0b8269c

yungwine requested a review from Copilot December 22, 2025 08:22

Copilot started reviewing on behalf of yungwine December 22, 2025 08:23 View session

Copilot AI reviewed Dec 22, 2025

View reviewed changes

yungwine merged commit 4d21162 into ton-blockchain:dev Dec 22, 2025
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add more commands tests #500

Add more commands tests #500

Uh oh!

yungwine commented Dec 22, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 22, 2025

Uh oh!

Copilot AI Dec 22, 2025

Uh oh!

Copilot AI Dec 22, 2025

Uh oh!

Copilot AI Dec 22, 2025

Uh oh!

Copilot AI Dec 22, 2025

Uh oh!

Copilot AI Dec 22, 2025

Uh oh!

Copilot AI Dec 22, 2025

Uh oh!

Copilot AI Dec 22, 2025

Uh oh!

Copilot AI Dec 22, 2025

Uh oh!

Copilot AI Dec 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	assert "account status is empty" in str(e)
	assert "account status is empty" in str(e.value)

	assert 'Pool with the same parameters already exists' in str(e)
	assert 'Pool with the same parameters already exists' in str(e.value)

	def create_backup(self, args: list) -> typing.Union[int, None]:
	def create_backup(self, args: list) -> Optional[int]:

-	except Exception:
-		pass
+	except Exception as exc:
+		# Log the error but continue with ADNL connection check
+		local.add_log(f"Failed to get validator config for ADNL check: {exc}", "warning")

Add more commands tests #500

Add more commands tests #500

Uh oh!

Conversation

yungwine commented Dec 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant