Skip to content

Conversation

@DanShaders
Copy link
Contributor

@DanShaders DanShaders commented Oct 20, 2025

TODO:

  • Make sure this works on Windows
  • Remove all manual -D.*_FOUND=1 flags in build scripts

@DanShaders DanShaders force-pushed the cmake branch 2 times, most recently from 719d14d to c266f6d Compare October 20, 2025 17:50
@Edgar71769
Copy link

TODO:

  • Make sure this works on Windows
  • Remove all manual -D.*_FOUND=1 flags in build scripts

@DanShaders DanShaders marked this pull request as ready for review October 22, 2025 03:25
Instead, put them into an object library and use it in 3 different
validator targets.
OUTPUT parameter is relative to the current binary directory by default,
so we need to explicitly use ${CMAKE_CURRENT_SOURCE_DIR}.
I faced some unexpected backlash from other developers because of
disabling it in ton-blockchain#1844.
@EmelyanenkoK EmelyanenkoK merged commit b118ab3 into ton-blockchain:testnet Oct 27, 2025
16 checks passed
@DanShaders DanShaders deleted the cmake branch October 27, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants