Skip to content

fix: handle colliding getter names #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kaladin13 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: handle colliding getter names #398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8886116
fix colliding getter names
Kaladin13 Jun 2, 2025
99c8570
Update src/lib/getter/useGetters.ts
Kaladin13 Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions src/lib/getter/useGetters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,24 @@ export type StateGetter = {
returnTypes: string[];
};

const parameterByName = (getters: StateGetter[], getterName: string, parameterName: string) =>
getters.find((_g) => _g.name === getterName)!.parameters.find((_p) => _p.name === parameterName)!;
const parameterByName = (
getters: StateGetter[],
getterName: string,
parameterName: string,
): Parameter => {
// loop for getter names collision
for (const getter of getters) {
if (getter.name !== getterName) continue;

for (const param of getter.parameters) {
if (param.name === parameterName) {
return param;
}
}
}

throw new Error("Malformed getter state: parameter not found");
};

type GetterState = {
getters: StateGetter[];
Expand Down