Skip to content

Conversation

@devdanzin
Copy link
Collaborator

This PR addresses a TODO in build.py: "Convert .gitignore to radon ignore patterns to make the build more efficient". However, timings show no difference in performance even with a lot of added Python files in ignored directories. That happens because radon is called only with modified files from given revisions as targets, so the build is already optimal in this sense.

This PR serves only to document this exploration. Leaving it open for a while in case we can identify a scenario it would help with.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (acf39d2) to head (7959156).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   95.46%   95.52%   +0.05%     
==========================================
  Files          26       26              
  Lines        1346     1364      +18     
  Branches      287      291       +4     
==========================================
+ Hits         1285     1303      +18     
  Misses         37       37              
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonybaloney
Copy link
Owner

lmk when this is ready to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants