-
Notifications
You must be signed in to change notification settings - Fork 2
Split non-Devvit-specific helpers into a separate package #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ight not be the correct version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts this project to a monorepo and adds an additional
toolbox-storagepackage which contains all the non-Devvit-specific logic. This will let us use these helpers for Toolbox itself as well, which means we'll eliminate any issues stemming from implementation differences between this library and Toolbox itself.This PR also actually exports the subreddit config classes from the new package - they were previously accessible via
ToolboxClientmethods, but the classes themselves weren't actually exposed for direct use.Breaking changes:
toolbox-devvitpackage no longer exports most of the things it used to. The rest of them need to be imported fromtoolbox-storageinstead if necessary; this should mostly impact Typescript consumers, who will want to addtoolbox-storageto theirdevDependenciesif they need to manually import its types.TODO:
@toolbox-team/storageintoolbox-devvitpackages/foo/v0.0.0; the "latest release" label on the releases page will just mean nothing--workspaces