-
Notifications
You must be signed in to change notification settings - Fork 26
feat(official-mcp-registry): Implement Federated Registry Provider for local and official package support #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Seey215
wants to merge
4
commits into
main
Choose a base branch
from
feat/registry-provider-anthropic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8bd65c2
feat(official-mcp-registry): Implement Federated Registry Provider fo…
Seey215 2ef73d9
feat(registry): Initialize Registry Factory with local repository in …
Seey215 a0a91b2
feat(registry): Update Registry Provider documentation and improve in…
Seey215 660d7ff
feat(registry): Enhance FederatedRegistryProvider and improve type de…
Seey215 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,5 +1,7 @@ | ||||||||
| import type { Tool } from "@modelcontextprotocol/sdk/types.js"; | ||||||||
| import type { ToolExecutor } from "../executor/executor-types"; | ||||||||
| import { getRegistryProvider } from "../registry/registry-factory"; | ||||||||
| import type { IRegistryProvider } from "../registry/registry-types"; | ||||||||
| import type { PackageRepository } from "./package-repository"; | ||||||||
| import type { MCPServerPackageConfig, MCPServerPackageConfigWithTools } from "./package-types"; | ||||||||
|
|
||||||||
|
|
@@ -8,7 +10,6 @@ export class PackageSO { | |||||||
| private readonly _packageName: string, | ||||||||
| private readonly _config: MCPServerPackageConfig, | ||||||||
| private readonly _packageInfo: { category?: string; validated?: boolean }, | ||||||||
| _repository: PackageRepository, | ||||||||
| private readonly _executor: ToolExecutor, | ||||||||
| ) {} | ||||||||
|
|
||||||||
|
|
@@ -36,10 +37,19 @@ export class PackageSO { | |||||||
| repository: PackageRepository, | ||||||||
| executor: ToolExecutor, | ||||||||
| ): Promise<PackageSO> { | ||||||||
| const config = repository.getPackageConfig(packageName); | ||||||||
| // Use FederatedRegistryProvider to support both local and official packages | ||||||||
|
||||||||
| // Use FederatedRegistryProvider to support both local and official packages | |
| // Use FederatedRegistryProvider, which checks for local packages first and falls back to the official registry if not found locally. | |
| // This is the key behavior that differs from the previous implementation. |
Outdated
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] This comment could be more specific - it's retrieving category and validation metadata from the local packages-list.json index, which may not exist for official packages. Consider clarifying: 'Get package metadata (category, validated) from local repository index if available'.
Suggested change
| // Get package metadata from local repository | |
| // Get package metadata (category, validated) from local repository index if available. | |
| // Note: This may not exist for official packages. |
Outdated
Copilot
AI
Nov 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type assertion 'as MCPServerPackageConfig' is unnecessary here. The config is already checked for null on line 44, and the IRegistryProvider.getPackageConfig signature returns 'Promise<unknown | null>'. Since the method is typed to return 'unknown', consider updating the IRegistryProvider interface to have a generic type parameter or change the return type to 'Promise<MCPServerPackageConfig | null>' for type safety without requiring assertions.
Suggested change
| return new PackageSO(packageName, config as MCPServerPackageConfig, packageInfo, executor); | |
| return new PackageSO(packageName, config, packageInfo, executor); |
162 changes: 162 additions & 0 deletions
162
src/domains/registry/__tests__/federated-registry-provider.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| import { beforeEach, describe, expect, it, vi } from "vitest"; | ||
| import type { MCPServerPackageConfig } from "../../package/package-types"; | ||
| import { FederatedRegistryProvider } from "../providers/federated-registry-provider"; | ||
| import type { LocalRegistryProvider } from "../providers/local-registry-provider"; | ||
| import type { OfficialRegistryProvider } from "../providers/official-registry-provider"; | ||
|
|
||
| describe("FederatedRegistryProvider", () => { | ||
| let mockLocalProvider: LocalRegistryProvider; | ||
| let mockOfficialProvider: OfficialRegistryProvider; | ||
| let provider: FederatedRegistryProvider; | ||
|
|
||
| beforeEach(() => { | ||
| // Mock LocalRegistryProvider | ||
| mockLocalProvider = { | ||
| getPackageConfig: vi.fn(), | ||
| exists: vi.fn(), | ||
| } as unknown as LocalRegistryProvider; | ||
|
|
||
| // Mock OfficialRegistryProvider | ||
| mockOfficialProvider = { | ||
| getPackageConfig: vi.fn(), | ||
| exists: vi.fn(), | ||
| search: vi.fn(), | ||
| } as unknown as OfficialRegistryProvider; | ||
|
|
||
| provider = new FederatedRegistryProvider(mockLocalProvider, mockOfficialProvider); | ||
| }); | ||
|
|
||
| describe("getPackageConfig", () => { | ||
| it("should return local config when package exists locally", async () => { | ||
| // Arrange | ||
| const packageName = "@modelcontextprotocol/server-filesystem"; | ||
| const mockConfig: MCPServerPackageConfig = { | ||
| type: "mcp-server", | ||
| runtime: "node", | ||
| packageName, | ||
| name: "Filesystem Server", | ||
| description: "A server for filesystem operations", | ||
| }; | ||
|
|
||
| vi.spyOn(mockLocalProvider, "getPackageConfig").mockResolvedValue(mockConfig); | ||
|
|
||
| // Act | ||
| const result = await provider.getPackageConfig(packageName); | ||
|
|
||
| // Assert | ||
| expect(result).toEqual(mockConfig); | ||
| expect(mockLocalProvider.getPackageConfig).toHaveBeenCalledWith(packageName); | ||
| expect(mockOfficialProvider.getPackageConfig).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it("should query official provider when local returns null", async () => { | ||
| // Arrange | ||
| const packageName = "@toolsdk.ai/tavily-mcp"; | ||
| const officialConfig: MCPServerPackageConfig = { | ||
| type: "mcp-server", | ||
| runtime: "node", | ||
| packageName, | ||
| name: "Tavily MCP Server", | ||
| description: "MCP server for Tavily search", | ||
| }; | ||
|
|
||
| vi.spyOn(mockLocalProvider, "getPackageConfig").mockResolvedValue(null); | ||
| vi.spyOn(mockOfficialProvider, "getPackageConfig").mockResolvedValue(officialConfig); | ||
|
|
||
| // Act | ||
| const result = await provider.getPackageConfig(packageName); | ||
|
|
||
| // Assert | ||
| expect(result).toEqual(officialConfig); | ||
| expect(mockLocalProvider.getPackageConfig).toHaveBeenCalledWith(packageName); | ||
| expect(mockOfficialProvider.getPackageConfig).toHaveBeenCalledWith(packageName); | ||
| }); | ||
|
|
||
| it("should return null when both providers return null", async () => { | ||
| // Arrange | ||
| const packageName = "non-existent-package"; | ||
|
|
||
| vi.spyOn(mockLocalProvider, "getPackageConfig").mockResolvedValue(null); | ||
| vi.spyOn(mockOfficialProvider, "getPackageConfig").mockResolvedValue(null); | ||
|
|
||
| // Act | ||
| const result = await provider.getPackageConfig(packageName); | ||
|
|
||
| // Assert | ||
| expect(result).toBeNull(); | ||
| }); | ||
|
|
||
| it("should return null when official provider throws error", async () => { | ||
| // Arrange | ||
| const packageName = "@toolsdk.ai/tavily-mcp"; | ||
|
|
||
| vi.spyOn(mockLocalProvider, "getPackageConfig").mockResolvedValue(null); | ||
| vi.spyOn(mockOfficialProvider, "getPackageConfig").mockRejectedValue( | ||
| new Error("Network error"), | ||
| ); | ||
|
|
||
| // Act | ||
| const result = await provider.getPackageConfig(packageName); | ||
|
|
||
| // Assert | ||
| expect(result).toBeNull(); | ||
| }); | ||
| }); | ||
|
|
||
| describe("exists", () => { | ||
| it("should return true when package exists locally", async () => { | ||
| // Arrange | ||
| const packageName = "@modelcontextprotocol/server-filesystem"; | ||
| vi.spyOn(mockLocalProvider, "exists").mockResolvedValue(true); | ||
|
|
||
| // Act | ||
| const result = await provider.exists(packageName); | ||
|
|
||
| // Assert | ||
| expect(result).toBe(true); | ||
| expect(mockLocalProvider.exists).toHaveBeenCalledWith(packageName); | ||
| expect(mockOfficialProvider.exists).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it("should check official provider when local returns false", async () => { | ||
| // Arrange | ||
| const packageName = "@toolsdk.ai/tavily-mcp"; | ||
| vi.spyOn(mockLocalProvider, "exists").mockResolvedValue(false); | ||
| vi.spyOn(mockOfficialProvider, "exists").mockResolvedValue(true); | ||
|
|
||
| // Act | ||
| const result = await provider.exists(packageName); | ||
|
|
||
| // Assert | ||
| expect(result).toBe(true); | ||
| expect(mockLocalProvider.exists).toHaveBeenCalledWith(packageName); | ||
| expect(mockOfficialProvider.exists).toHaveBeenCalledWith(packageName); | ||
| }); | ||
|
|
||
| it("should return false when both providers return false", async () => { | ||
| // Arrange | ||
| const packageName = "non-existent-package"; | ||
| vi.spyOn(mockLocalProvider, "exists").mockResolvedValue(false); | ||
| vi.spyOn(mockOfficialProvider, "exists").mockResolvedValue(false); | ||
|
|
||
| // Act | ||
| const result = await provider.exists(packageName); | ||
|
|
||
| // Assert | ||
| expect(result).toBe(false); | ||
| }); | ||
|
|
||
| it("should return false when official provider throws error", async () => { | ||
| // Arrange | ||
| const packageName = "@toolsdk.ai/tavily-mcp"; | ||
| vi.spyOn(mockLocalProvider, "exists").mockResolvedValue(false); | ||
| vi.spyOn(mockOfficialProvider, "exists").mockRejectedValue(new Error("Network error")); | ||
|
|
||
| // Act | ||
| const result = await provider.exists(packageName); | ||
|
|
||
| // Assert | ||
| expect(result).toBe(false); | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 52 is a duplicate of line 51. This duplicated spy setup should be removed.