fix: replace git submodule with Julia Artifacts for test fixtures#7
Merged
fix: replace git submodule with Julia Artifacts for test fixtures#7
Conversation
Git submodules are incompatible with Julia General registry (git archive doesn't include submodule contents, causing tree-sha1 mismatch). - Add test/Artifacts.toml with lazy toon_spec artifact (v3.0.1) - Update test_spec_fixtures.jl to use artifact instead of submodule - Add LazyArtifacts to test dependencies - Remove git submodule and deprecated download_fixtures.jl
Collaborator
Author
|
This one pass but should fail |
GitHub release tarballs extract contents into a versioned subdirectory (e.g., spec-3.0.1/). Updated artifact path detection to dynamically find this subdirectory instead of assuming content is at the root. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
Author
|
LGTM now... https://github.com/toon-format/ToonFormat.jl/actions/runs/20456298199/job/58779037140?pr=7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git submodules are incompatible with Julia General registry (git archive doesn't include submodule contents, causing tree-sha1 mismatch).
Linked Issue
Helps #4 and #3
Closes #
Description
Type of Change
Changes Made
SPEC Compliance
Testing
Pre-submission Checklist
Breaking Changes
Additional Context