-
Notifications
You must be signed in to change notification settings - Fork 53
Fix setup-uv cache dependency config in lint and test workflows #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smortezah
wants to merge
5
commits into
toon-format:main
Choose a base branch
from
smortezah:fix/uv-cache
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fc68878
feat: add pull request description template
smortezah 97bc4d8
Merge branch 'toon-format:main' into main
smortezah 05ff454
Merge branch 'toon-format:main' into main
smortezah 1260099
chore: add cache-dependency-glob for uv setup in lint and test workflows
smortezah 8e85508
Delete .copilot-pull-request-description-instructions.md
smortezah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,124 @@ | ||
| ## Description | ||
|
|
||
| <!-- Provide a clear and concise description of your changes --> | ||
|
|
||
| ## Type of Change | ||
|
|
||
| <!-- Mark the relevant option with an [x] --> | ||
|
|
||
| - [ ] Bug fix (non-breaking change that fixes an issue) | ||
| - [ ] New feature (non-breaking change that adds functionality) | ||
| - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
| - [ ] Documentation update | ||
| - [ ] Refactoring (no functional changes) | ||
| - [ ] Performance improvement | ||
| - [ ] Test coverage improvement | ||
|
|
||
| ## Related Issues | ||
|
|
||
| <!-- Link any related issues using #issue_number --> | ||
|
|
||
| Closes # | ||
|
|
||
| ## Changes Made | ||
|
|
||
| <!-- List the main changes in this PR --> | ||
|
|
||
| - | ||
| - | ||
| - | ||
|
|
||
| ## SPEC Compliance | ||
|
|
||
| <!-- If this PR relates to the TOON spec, indicate which sections are affected --> | ||
|
|
||
| - [ ] This PR implements/fixes spec compliance | ||
| - [ ] Spec section(s) affected: | ||
| - [ ] Spec version: | ||
|
|
||
| ## Testing | ||
|
|
||
| <!-- Describe the tests you added or ran --> | ||
|
|
||
| - [ ] All existing tests pass | ||
| - [ ] Added new tests for changes | ||
| - [ ] Tested on Python 3.8 | ||
| - [ ] Tested on Python 3.9 | ||
| - [ ] Tested on Python 3.10 | ||
| - [ ] Tested on Python 3.11 | ||
| - [ ] Tested on Python 3.12 | ||
|
|
||
| ### Test Output | ||
|
|
||
| ```bash | ||
| # Paste test output here | ||
| ``` | ||
|
|
||
| ## Code Quality | ||
|
|
||
| <!-- Confirm code quality checks --> | ||
|
|
||
| - [ ] Ran `ruff check src/toon_format tests` - no issues | ||
| - [ ] Ran `ruff format src/toon_format tests` - code formatted | ||
| - [ ] Ran `mypy src/toon_format` - no critical errors | ||
| - [ ] All tests pass: `pytest tests/ -v` | ||
|
|
||
| ## Checklist | ||
|
|
||
| <!-- Mark completed items with an [x] --> | ||
|
|
||
| - [ ] My code follows the project's coding standards (PEP 8, line length 100) | ||
| - [ ] I have added type hints to new code | ||
| - [ ] I have added tests that prove my fix/feature works | ||
| - [ ] New and existing tests pass locally | ||
| - [ ] I have updated documentation (README.md, CLAUDE.md if needed) | ||
| - [ ] My changes do not introduce new dependencies | ||
| - [ ] I have maintained Python 3.8+ compatibility | ||
| - [ ] I have reviewed the [TOON specification](https://github.com/toon-format/spec) for relevant sections | ||
|
|
||
| ## Performance Impact | ||
|
|
||
| <!-- If applicable, describe any performance implications --> | ||
|
|
||
| - [ ] No performance impact | ||
| - [ ] Performance improvement (describe below) | ||
| - [ ] Potential performance regression (describe and justify below) | ||
|
|
||
| <!-- Details: --> | ||
|
|
||
| ## Breaking Changes | ||
|
|
||
| <!-- If this is a breaking change, describe the migration path for users --> | ||
|
|
||
| - [ ] No breaking changes | ||
| - [ ] Breaking changes (describe migration path below) | ||
|
|
||
| <!-- Migration path: --> | ||
|
|
||
| ## Screenshots / Examples | ||
|
|
||
| <!-- If applicable, add screenshots or example output --> | ||
|
|
||
| ```python | ||
| # Example usage | ||
| ``` | ||
|
|
||
| Output: | ||
| ``` | ||
| # Example output | ||
| ``` | ||
|
|
||
| ## Additional Context | ||
|
|
||
| <!-- Add any other context about the PR here (optional) --> | ||
|
|
||
| ## Checklist for Reviewers | ||
|
|
||
| <!-- For maintainers reviewing this PR --> | ||
|
|
||
| - [ ] Code changes are clear and well-documented | ||
| - [ ] Tests adequately cover the changes | ||
| - [ ] Documentation is updated | ||
| - [ ] No security concerns | ||
| - [ ] Follows TOON specification | ||
| - [ ] Backward compatible (or breaking changes are justified and documented) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.