Prevent stack overflow crashes with recursion limit#21
Merged
mattt merged 9 commits intotoon-format:mainfrom Feb 6, 2026
Merged
Prevent stack overflow crashes with recursion limit#21mattt merged 9 commits intotoon-format:mainfrom
mattt merged 9 commits intotoon-format:mainfrom
Conversation
mattt
requested changes
Feb 5, 2026
Collaborator
mattt
left a comment
There was a problem hiding this comment.
Thanks for opening this PR, @rickhohler! Left some comments with suggested changes.
7f74155 to
5c5ebf3
Compare
Reorder declarations
mattt
approved these changes
Feb 6, 2026
Collaborator
|
Thanks for your help with this, @rickhohler! I worked through the remaining feedback and adjusted the recursion limit to 32, matching the decoding limit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a missing safety mechanism in
TOONEncoderwhere deeply nested structures could cause a stack overflow crash.Changes
recursionLimit: New property onTOONEncoder(default: 1000).Keyed,Unkeyed, andSingleValueencoding containers.EncodingError.invalidValueif the recursion limit is exceeded.Verification
testDeepRecursioninBugHuntingTestswhich confirms that the encoder now throws a catchable error instead of crashing the process.