fixing types for issue: #10

toonvanstrijp · Jul 3, 2019 · bc8bc59 · bc8bc59
1 parent 53273e8
commit bc8bc59
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/lib/services/i18n.service.ts b/lib/services/i18n.service.ts
@@ -20,7 +20,7 @@ export class I18nService {
   public translate(
     lang: string,
     key: string,
-    args: Array<{ [k: string]: any } | string> = [],
+    args?: Array<{ [k: string]: any } | string> | { [k: string]: any },
   ) {
     let translation = this.translations[lang][key];
 
@@ -37,8 +37,11 @@ export class I18nService {
         return undefined;
       }
     }
-    if (args && args.length > 0) {
-      translation = format(translation, ...(args || []));
+    if (args || (args instanceof Array && args.length > 0)) {
+      translation = format(
+        translation,
+        ...(args instanceof Array ? args || [] : [args]),
+      );
     }
     return translation;
   }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "nestjs-i18n",
-  "version": "2.2.1",
+  "version": "2.2.2",
   "description": "",
   "author": "Toon van Strijp",
   "repository": {

diff --git a/tests/i18n.spec.ts b/tests/i18n.spec.ts
@@ -34,6 +34,10 @@ describe('i18n module', () => {
     expect(i18nService.translate('nl', 'PRODUCT.NEW', [{ name: 'Test' }])).toBe(
       'Nieuw Product: Test',
     );
+
+    expect(i18nService.translate('nl', 'PRODUCT.NEW', { name: 'Test' })).toBe(
+      'Nieuw Product: Test',
+    );
   });
 
   it('i18n service should return array translation', async () => {