Skip to content

Log action on get terms failure#7187

Merged
kkartunov merged 1 commit intomasterfrom
kkartunov-patch-4
Feb 26, 2026
Merged

Log action on get terms failure#7187
kkartunov merged 1 commit intomasterfrom
kkartunov-patch-4

Conversation

@kkartunov
Copy link
Collaborator

No description provided.

@kkartunov kkartunov requested a review from jmgasper as a code owner February 26, 2026 12:30
@kkartunov kkartunov merged commit 57a1b31 into master Feb 26, 2026
5 of 6 checks passed
function onGetTermsDone(state, action) {
if (action.error) {
logger.error('Failed to get terms!', action.payload);
logger.error('Failed to get terms!', action);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ security]
Logging the entire action object instead of just action.payload could potentially expose sensitive information, depending on what action contains. Consider reviewing the contents of action to ensure no sensitive data is logged, or revert to logging only action.payload if it is sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant