Repository navigation
fix(mem-off): make the claude-mem arm's wait.sh actually wait - #63
Open
thedotmack wants to merge 1 commit into
Open
thedotmack wants to merge 1 commit into
thedotmack wants to merge 1 commit into
Conversation
The worker's GET /api/processing-status returns {isProcessing, queueDepth,
parkedSessions}. wait.sh read `pending` and `processing`, which never exist,
so the check passed immediately and the next issue started while the
observer was still writing memory from the previous one. Read the real keys
and treat an unreachable worker or a malformed response as busy.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vk749zuXTwpz48LMGrjpCK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
harness/arms/claude-mem/wait.shcheckedpendingandprocessingon the worker'sGET /api/processing-statusresponse. The claude-mem worker returns{isProcessing, queueDepth, parkedSessions}(DataRoutes.ts,handleGetProcessingStatus), so neither key ever exists, the condition was always true, andwait.shreturned 0 on its first poll.In the sequencer, the next issue's session would then start while the observer was still writing memory from the previous one. That skews the claude-mem arm on exactly the linked issues (4/5/7/8) the memory delta measures.
This change reads the real keys and requires
isProcessing == false,queueDepth == 0andparkedSessions == 0. An unreachable worker or a response missing these keys counts as busy, so the script hits the existing timeout and exits non-zero instead of passing silently.Verified
{"isProcessing":true,"queueDepth":503,"parkedSessions":0}, the old check exits 0 and the new script keeps polling until it times out (exit 1).{}and unreachable port → keep waiting / exit 1 on timeout.Only
wait.shchanges. The arm's other open items (pinned version,wipe_check.sh, injected-context dump,receipt.sh/usage.sh) are still to come; claude-mem will follow up on those.🤖 Generated with Claude Code
https://claude.ai/code/session_01Vk749zuXTwpz48LMGrjpCK