Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OPS-695] Adding Workload Identity Federation support to NPM authentication with Google Artifacts #385

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[OPS-695] Adding Workload Identity Federation support to NPM authentication with Google Artifacts #385

wants to merge 2 commits into from

Conversation

cust0m
Copy link

@cust0m cust0m commented Feb 20, 2025 •
edited by jira bot
Loading

OPS-695 Adding Workload Identity Federation support to NPM authentication with Google Artifacts

Description

Adding Workload Identity Federation support to NPM authentication with Google Artifacts

How to test

  • FIXME: Add the steps describing how to verify your changes

Development checks

  • Add changeset according to guidelines (if needed)
PR commands

List of available commands:

  • @toptal-anvil ping reviewers - Ping teams for review

@cust0m cust0m requested a review from a team as a code owner February 20, 2025 14:14
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b13cc3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

denieler
denieler reviewed Feb 20, 2025
View reviewed changes
yarn-install/action.yml
@@ -18,6 +18,9 @@ inputs:
npm-gar-token:
description: Repository npm Artifact Registry access token `NPM_GAR_TOKEN`. Required when using self-hosted runners with npm in GAR (Google Artifact Registry, the npm registry works as a proxy-cache, downloading and storing the public npm packages)
required: false
npm-gar-wif-token:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not to replace the npm-gar-token?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @denieler , just to not cause the workflows that are using npm-gar-token to fail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cust0m I think we can mark this change as Breaking change and force all users to start using the new token when they will be upgrading the version of this action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denieler denieler denieler left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cust0m @denieler