Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total pixi's configuration supports for Python.gitignore #578

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kasi-x
Copy link

@kasi-x kasi-x commented Jun 22, 2024

Pull Request

Thank you for contributing to @toptal/gitignore and https://www.gitignore.io.

New or update

Select the appropriate check box for this pull request. This helps when merging to ensure there are no conflicts with other templates or misunderstandings of how thee template list works.

New

  • Template - New .gitignore template
  • Composition - Template made from smaller templates
  • Inheritance - Template similar to an existing template
  • Patch - Template extending functionality of existing template

Update

  • Template - Update existing .gitignore template

Details

Reasons for making this change:

pixi is a package manager. (Almost used for Python developing)
I want to append pixi support for this project.
This appendix format is same as previous ones, pyenv, pipenv, pdm, poetry.
#576 is a proposal to append pixi support too. But that is not enough supports of pixi.

This pull requests include two type of changes for pixi's support.

First one is for pixi.lock. It just follows precedent cases(pipenv, poetry, pdm).
I don't think there is any problem to append this line.

Second one is for .pixi.
pixi create .pixi directory, just like Python's venv module creates one in the .venv directory. .pixi is a directory for setting up virtualenv.
It is recommended not to include this directory in version control in pixi system.

Why .pixi is needed in gitignore.

When initialize pixi project (by running pixi init command), pixi automatically add the line of .pixi to .gitignore file. (If already exist .pixi in user's .gitignore file, pixi doesn't change anything.)
But user may use this project's template after initialized pixi.
This change doesn't cause any breaking change. Appending .pixi in this project's template is reasonable.

@kasi-x kasi-x requested review from a team as code owners June 22, 2024 09:23
@kasi-x kasi-x requested review from alexmcode and yusufzmly and removed request for a team June 22, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant