Tests for type embeds #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torch2424
approved these changes
Mar 15, 2021
| @@ -30,8 +30,8 @@ async function compileStreaming(source) { | |||
| if (WebAssembly.compileStreaming) { | |||
| return WebAssembly.compileStreaming(source); | |||
| } | |||
| source = await Promise.resolve(souce); | |||
| if (source instanceof Response) { | |||
| source = await Promise.resolve(source); | |||
There was a problem hiding this comment.
Oops, didn't know I had a type here 😂
There was a problem hiding this comment.
This was my typo, not yours 😅
Cheers mate! Yeah, already wrote a bunch more tests. Definitely looking to fill it up more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, yes, another PR. @torch2424 I hope you don’t feel like this is becoming a hostile takeover or anything. The reason for a 2nd PR is actually exactly the opposite — I wanna make sure you still feel like this is your code base. I just wanna help out a bit. The PR goes into my other PR #70, to keep things a little easier to digest. I also don’t want to continue working on #70 until I have tests to make sure I am not just scewing everything up (as writing the tests has already uncovered some bugs 🙈 )
What’s in here?
The goal of this PR is to refactor test infrastructure so that it’s easier to add tests and to have the same tests be run in the browser and in Node. This will become increasingly important with more diverging Wasm engine feature support. Specifically:
asc.tsthat gets compiled just in time before the tests are run. (In the future we can expose hooks here to adjust the flags for the ASC compiler for experimental features etc).@torch2424 Are you comfortable with this and merging it into my other branch?