Skip to content

WIP: feat: type gen #98 #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WIP: feat: type gen #98 #99

wants to merge 1 commit into from

Conversation

mathe42
Copy link
Contributor

@mathe42 mathe42 commented Sep 24, 2021

Basic idea. Code is not final!

I currently just write the config json file to disk and have a node script to generate the types. This process will be integrated in the transform step.

Copy link
Owner

@torch2424 torch2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR @mathe42 !!! 😄 🎉

I'll cc @surma as they may have more insight on this than me, but! I will say, so far this looks great 😄

@mathe42
Copy link
Contributor Author

mathe42 commented Sep 27, 2021

I looked at the internals a lot and learned a lot so I will properly rewrite most of it.
I can get more information: Optional + Rest parameter; name of parameter. (This is why I did #100 to learn how this works :D.)

@mathe42 mathe42 mentioned this pull request Sep 28, 2021
5 tasks
@mathe42
Copy link
Contributor Author

mathe42 commented Sep 28, 2021

closed in favor of #101

@mathe42 mathe42 closed this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants