Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE-50 Only show division-related content on Work and Blog pages #380

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

bmispelon
Copy link
Collaborator

@bmispelon bmispelon commented Mar 14, 2025

Link to Ticket

Description of Changes Made

Changed the logic of related_blog_posts (resp. related_works) for BlogPage (resp. WorkPage) to take the page's final_division into account. If the page is associated with a division, then only blog posts (resp. work pages) will be displayed under the "More" heading on the page.

How to Test

See testing notes on ticket

Screenshots

I ran out of time for screenshots, sorry (I'm struggling to get the right type of pages set up locally to demonstrate the issue, but I hope the unit tests added will demonstrate the fix well enough).

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@bmispelon bmispelon marked this pull request as ready for review March 14, 2025 13:32
Copy link
Collaborator

@SharmaineLim SharmaineLim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, Baptiste :)

I have a small question/suggestion, but this work can go ahead whether we push through with it or not.

@SharmaineLim SharmaineLim merged commit 5a628ae into main Mar 19, 2025
4 checks passed
@SharmaineLim SharmaineLim deleted the fix/twe-50-blogpage-related-posts-same-division branch March 19, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants