[TWE-660] Add VWO code to base page #401
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbridge
requested review from
alxbridge and
nickmoreton
and removed request for
alxbridge and
nickmoreton
nickmoreton
reviewed
Jul 31, 2025
There was a problem hiding this comment.
@damwaingames This looks good but I left a suggestion for you.
Comment on lines
+36
to
+39
| <script> | ||
| window.VWO = window.VWO || []; | ||
| window.VWO.init = window.VWO.init || function(state) { window.VWO.consentState = state; } | ||
| </script> |
There was a problem hiding this comment.
Note: This code exists in the RNIB base but I'm not actually sure whether it's essential to this implementation?
Comment on lines
+20
to
+24
| bindEvents() { | ||
| window.addEventListener('CassieSubmittedConsent', () => | ||
| this.toggleVWO(), | ||
| ); | ||
| } |
There was a problem hiding this comment.
Note: Whatever Cassie is I don't think is relevant to the this site?
| } | ||
|
|
||
| toggleVWO() { | ||
| const isEnabled = getCookie('VWOCookie') === 'Yes'; |
There was a problem hiding this comment.
Question: Is setting up this cookie on us?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TWE-660
Description of Changes Made
Edited the base_page.html to insert the VWO script to the heads of all pages, so that the marketing team can get access to the visitor engagement data and testing features of that site.
How to Test
View several pages and ensure that the VWO code appears in the head section when you inspect the source.
Screenshots
This isn't a visible change.
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library