-
Notifications
You must be signed in to change notification settings - Fork 3
TWE-667 | Blog page updates #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| <div class="grid grid--spacer-large"> | ||
| {% include "patterns/molecules/title-filters/title-filters.html" with item=page tags=tags %} | ||
|
|
||
| {% include "patterns/molecules/title-filters/title-filters.html" with item=page tags=tags introduction=page.introduction page_links=page.page_links %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed, probably best to add the intro and page links below in .page-listing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, yeah. Will have a look after my calls and make some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<ul class="page-listing page-listing--blog">
<li class="listing page-listing__item rich-text">
<p>{{ page.introduction|linebreaksbr }}</p>
{% if page.page_links %}
<div class="styled-page-links">
{% for block in page.page_links %}
{% include_block block %}
{% endfor %}
</div>
{% endif %}
</li>
{% for post in blog_posts %}
...
should do the trick
- Remove separate migration files 0030 and 0031 - Create single migration 0030_blogindexpage_introduction_and_page_links - Combines both field additions into one migration as requested in PR feedback
|
@helenb and @shyusu4 - I've added the BE here and some FE, I just can't quite figure out how to place the new elements in the templates and make them stack in the way suggested by the design. The design is a bit outdated and doesn't have the filters but I'm working under the impression we need to keep those. Would you be able to help get this over the line please? Thanks |
| <h1 class="heading heading--mega">{{ item.title }}</h1> | ||
| </div> | ||
|
|
||
| {% if tags and not hide_tags %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note, we not longer need hide_tags as the tags were re-added in #403
We're keeping the filters but we're hiding them when there is an intro/styled links (see https://torchbox.slack.com/archives/C06AQA4D0RX/p1761662574666309?thread_ts=1761658267.864189&cid=C06AQA4D0RX) Also, here are the updated FE screenshots:
|
|
Hey @kevinhowbrook do you have what you need now from @shyusu4 ? Let me know if you need code review. |



Link to Ticket
Link to design
Description of Changes Made
This PR introduces 2 new fields to the blog index page:
Note
This is BE only, I added some FE but couldn't quite stack the elements correctls
How to Test
Screenshots
Expand to see more
MR Checklist
Unit tests
Documentation
Browser testing
Data protection
Light and dark mode
Accessibility
Sustainability
Pattern library