-
Notifications
You must be signed in to change notification settings - Fork 20
Wagtail 72 maintenance #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Wagtail 72 maintenance #88
Conversation
Drop support for Wagtail 6.3 and Python 3.9 Add python3.14 to tox and pre-commit configs
Drop testing against python 3.9
pyproject.toml
Outdated
| requires-python = ">=3.9" | ||
| dependencies = [ | ||
| "Wagtail>=6.3", | ||
| "Wagtail>=7.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in two minds about this. 6.3 as an LTS is supported untill May 2026.
At the same time, it would be nice to push folks to move to at least 7.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's stick to the LTS policy, so leave >= 6.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to include tox tests for 6.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please. 1 should be enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated this.
Co-authored-by: Dan Braghiș <[email protected]>
|
Thanks for looking at the @zerolab Let me know if there's anything else needed. |
| - repo: https://github.com/astral-sh/ruff-pre-commit | ||
| # Keep in sync with .github/workflows/ruff.yml | ||
| rev: 'v0.14.2' | ||
| rev: 'v0.14.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you update this to latest ruff version? otherwise pre-commit.ci gets noisy
|
|
||
| ## Unreleased | ||
|
|
||
| - Remove support for Wagtail <7.0, Python < 3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not true, though. now that 6.3 is back in the picture
This pull request updates the project's Python and dependency support to include the latest versions, and aligns the testing and development tooling accordingly. The main changes focus on adding support for Python 3.14, updating Wagtail requirements to version 6.3+, and ensuring all testing environments and pre-commit hooks use the latest compatible versions.
Python and Dependency Version Support
.pre-commit-config.yaml,pyproject.toml,tox.ini) and removed Python 3.9 from supported versions. Updated theclassifiersand test environments to reflect this change.>=6.3Tooling and Testing Updates
pre-commit,tox,coverage, andwagtail-modeladmininpyproject.tomlruff-pre-commithook version in.pre-commit-config.yamlskipmissing_interpreters = trueintox.inito allow tests to pass even if some Python interpreters are not installed locally.