Open
Conversation
This way it's incredibly fast, rather than loading them all into memory and iterating. Especially useful for sites with large image libraries.
Collaborator
kevinhowbrook
left a comment
kevinhowbrook
left a comment
There was a problem hiding this comment.
Thanks for the suggestion jake - I'll have a look at this locally :)
| for image in Image.objects.all(): | ||
| self.update_wagtail_image(image, photos) | ||
| for photo, images in zip(photos, self.chunk_images(len(photos))): | ||
| images.update(file=f"unsplash-{photo.id}") |
Collaborator
There was a problem hiding this comment.
Won't image be a list var here, returned from chunk_images? .update() won't work.
Member
Author
There was a problem hiding this comment.
Slicing querysets generally produces querysets, but i'm not sure how that fairs with the mutation that chunk_images is doing.
In my testing it did return lists, although I thought that was something going weird as I had no images locally. If it doesn't work I'll just have to tweak chunk_images, but that shouldn't be too difficult.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way it's incredibly fast, rather than loading them all into memory and iterating. Especially useful for sites with large image libraries.
Untested in its whole, but the theory should be sound.