Refactor/block builder #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add test for conf_domain_prefix
the code to deal with these test cases is in the next PR
nimasmi
reviewed
Nov 1, 2021
wagtail_wordpress_import/test/tests/test_transform_styles_filter.py
Outdated
Show resolved
Hide resolved
docs/blockbuilder.md
Outdated
| ``` | ||
| Examples: | ||
|
|
||
| 1. Include the `h1-h6` HTML tags in the fall back block and not have their own block types. Just remove the `h1-h6` filter configuration items in your own settings. |
There was a problem hiding this comment.
Suggested change
| 1. Include the `h1-h6` HTML tags in the fall back block and not have their own block types. Just remove the `h1-h6` filter configuration items in your own settings. | |
| 1. Include the `h1`–`h6` HTML tags in the fallback block and not have their own block types. Just remove the `h1-h6` filter configuration items in your own settings. |
|
Hey @nimasmi Thanks for doing this so quickly. I have resubmitted the PR with changes in place. |
nimasmi
approved these changes
Nov 1, 2021
|
|
||
| Examples: | ||
|
|
||
| 1. Include the `h1 - h6` HTML tags in the fallback block and not have their own block types. Just remove the `h1 - h6` filter configuration items in your own settings. |
There was a problem hiding this comment.
Comment: h1 - h6 — well, that's not what I suggested, but it's not important.
There was a problem hiding this comment.
Ah now I see what you mean. I've made a note. I'm bound to be back in there soon and will update it then. Thanks
nickmoreton
added a commit
that referenced
this pull request
Nov 10, 2021
#64 developer tooling docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the PR for the other work done in #57
it needs to be reviewed before the import documents PR #57
codebase: https://projects.torchbox.com/projects/wordpress-to-wagtail-importer-package/tickets/75