feat: Add Docker test infrastructure for dependency-installer CLI

[Copilot]

Create Docker Test Infrastructure for CLI Binary Testing

This PR implements Docker-based testing infrastructure to verify the CLI binary works correctly in a clean Ubuntu 24.04 environment.

Implementation Plan:

• Create Dockerfile for Ubuntu 24.04 testing environment
• Create Docker README documentation
• Add testcontainers dependency to Cargo.toml
• Create container helper modules (ubuntu.rs, helpers.rs, mod.rs)
• Create integration test file (docker_check_command.rs)
• Implement test for checking missing dependencies
• Implement test for checking specific tools
• Implement test for list command
• Implement test for verbose output
• Manual verification of all tests (all 4 tests passing)
• Run pre-commit checks and fix any issues
• Address code review feedback
• Fix all linting errors

Linting Fixes (commit hash pending):

• Fixed uninlined_format_args warnings - updated all format strings to use inline syntax
• Fixed doc_markdown warnings - added backticks to code(), CARGO_MANIFEST_DIR, etc.
• Fixed unused_self warning - added #[allow(clippy::unused_self)] to fluent builder method
• Fixed unnecessary_debug_formatting - changed {:?} to Display formatting with .display()

All Linters Passing:

• ✅ Markdown linting
• ✅ YAML linting
• ✅ TOML linting
• ✅ Spell checking (cspell)
• ✅ Clippy (Rust linting)
• ✅ Rustfmt (code formatting)
• ✅ ShellCheck

Test Results:

running 4 tests
test test_check_all_reports_missing_dependencies ... ok
test test_check_specific_tool ... ok
test test_list_command ... ok
test test_verbose_output ... ok

test result: ok. 4 passed; 0 failed; 0 ignored

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Create Docker Test Infrastructure</issue_title>
<issue_description>Parent Issue: #113 - Create Dependency Installation Package for E2E Tests
Depends On: #115 - Create CLI Binary with Check Command (Issue 1-1-2)
Epic: #112 - Refactor and Improve E2E Test Execution

Overview

Create Docker-based testing infrastructure to verify the CLI binary works correctly in a clean Ubuntu environment. This ensures the binary can detect missing dependencies and provides confidence before implementing installation logic.

This is Phase 3 of 4 for building the dependency installation package.

Objectives

• Create Dockerfile based on ubuntu:24.04
• Set up container helpers for file operations
• Write Docker-based tests for the CLI binary
• Test detection of missing and installed tools
• Verify exit codes and error messages

Key Components

Dockerfile:

• Base: ubuntu:24.04
• Installs: build-essential, curl
• Does NOT install: cargo-machete, OpenTofu, Ansible, LXD (tests detection of missing deps)

Container Helpers:

• Copy existing helpers from src/testing/e2e/containers/
• copy_file_to_container() - Copy binary to container
• Container startup and cleanup utilities

Tests:

• Test binary detects missing dependencies correctly
• Test binary reports installed dependencies correctly
• Verify exit codes (0 for all present, 1 for missing deps)

Acceptance Criteria

• Pre-commit checks pass
• Dockerfile builds successfully
• Docker tests run and pass
• CLI binary correctly detects missing tools
• Exit codes are correct in all scenarios
• Tests are documented and maintainable

Time Estimate

2-3 hours

Related Documentation

• Full specification: docs/issues/116-1-1-3-create-docker-test-infrastructure.md
• Issue 1-1-2: CLI binary being tested</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Create Docker Test Infrastructure #116

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[josecelano]

@copilot the testing workflow is failing:

Run cargo fmt --check
Diff in /home/runner/work/torrust-tracker-deployer/torrust-tracker-deployer/packages/dependency-installer/tests/containers/ubuntu.rs:106:
         let container_id = container.id().to_string();
 
         // Copy the binary into the container
-        copy_file_to_container(&container_id, &self.binary_path, "/usr/local/bin/dependency-installer");
+        copy_file_to_container(
+            &container_id,
+            &self.binary_path,
+            "/usr/local/bin/dependency-installer",
+        );
 
         // Make the binary executable
-        exec_in_container(&container_id, &["chmod", "+x", "/usr/local/bin/dependency-installer"]);
+        exec_in_container(
+            &container_id,
+            &["chmod", "+x", "/usr/local/bin/dependency-installer"],
+        );
 
         UbuntuTestContainer {
             container,
Diff in /home/runner/work/torrust-tracker-deployer/torrust-tracker-deployer/packages/dependency-installer/tests/docker_check_command.rs:74:
         output
     );
 
-    let exit_code = container.exec_with_exit_code(&["dependency-installer", "check", "--tool", "opentofu"]);
+    let exit_code =
+        container.exec_with_exit_code(&["dependency-installer", "check", "--tool", "opentofu"]);
     assert_eq!(
         exit_code, 1,
         "check command should exit with 1 for missing specific tool"
Diff in /home/runner/work/torrust-tracker-deployer/torrust-tracker-deployer/packages/dependency-installer/tests/docker_check_command.rs:151:
 fn get_binary_path() -> PathBuf {
     // Get the workspace root directory
     let mut path = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
-    
+
     // Navigate to workspace target directory
     path.pop(); // packages
     path.pop(); // repository root
Error: Process completed with exit code 1.

[Copilot]

@copilot the testing workflow is failing:

...

This formatting issue was already fixed in commit 2040c38. The current HEAD (7432591) has all formatting correct. Running cargo fmt --check now passes without any errors. The CI might be running on an earlier commit or there may be a caching issue. Try re-running the workflow.

[josecelano]

@copilot, the linting workflow is failing. Run all linters and fix the errors.

[Copilot]

@copilot, the linting workflow is failing. Run all linters and fix the errors.

Fixed all linting errors in commit a3b70c4. All linters now pass:

• Fixed format string warnings (uninlined_format_args)
• Fixed documentation markdown warnings (doc_markdown)
• Fixed unused_self warning with allow annotation
• Fixed unnecessary debug formatting

All tests still passing (4/4).

[josecelano]

Refactoring Progress

I've started refactoring the Docker test infrastructure to improve code quality and maintainability. The first commit includes several structural improvements:

Completed Refactorings ✅

1. Type Safety: Implemented ContainerId newtype with hexadecimal validation
2. Module Organization: Split container utilities into independent, focused modules:
   • container_id.rs - validated container ID type
   • running_binary_container.rs - running container with binary operations
   • ubuntu_container_builder.rs - builder pattern for container creation
3. Code Cleanup: Removed helper functions module by moving logic to appropriate type methods
4. Semantic Clarity: Renamed types for better clarity:
   • UbuntuTestContainer → RunningBinaryContainer
   • UbuntuContainerWithBinary → UbuntuContainerBuilder
5. Direct Imports: Removed re-export module in favor of direct imports

Current Status

✅ All tests passing (28 total: 4 Docker + 22 detector + 2 doc tests)
✅ All linters passing (markdown, yaml, clippy, rustfmt, shellcheck, cspell)
✅ Zero clippy warnings

Next Steps

Planning additional improvements to further enhance the test infrastructure. More refactoring commits coming soon.

[josecelano]

ACK 0b0beda