Skip to content

Conversation

@josecelano
Copy link
Member

  • Updated error messages in test cases to include "Bad request" for better clarity when query parameters cannot be parsed.
  • Modified the From implementations for ParseQueryError and ParseAnnounceQueryError to include "Bad request" in the error messages.

@josecelano josecelano linked an issue Dec 2, 2024 that may be closed by this pull request
@josecelano josecelano self-assigned this Dec 2, 2024
@josecelano josecelano added Enhancement / Feature Request Something New - Developer - Torrust Improvement Experience labels Dec 2, 2024
@josecelano
Copy link
Member Author

ACK 3af1928

@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.12%. Comparing base (17e86c6) to head (3af1928).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1114   +/-   ##
========================================
  Coverage    76.12%   76.12%           
========================================
  Files          173      173           
  Lines        11347    11347           
  Branches     11347    11347           
========================================
  Hits          8638     8638           
  Misses        2514     2514           
  Partials       195      195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josecelano josecelano merged commit 7faa54c into torrust:develop Dec 2, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

- Developer - Torrust Improvement Experience Enhancement / Feature Request Something New

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error message in announce response

2 participants