fix: move NullSymbol declaration inside createSafeContext function #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update resolves an issue with
NullSymbolin thecreateSafeContextfunction. Previously, a globalNullSymbolwas used, which could lead to conflicts between different contexts, especially when multiplecreateSafeContextcalls were used. Now, a uniqueNullSymbolis generated for each context to ensure no conflicts occur.Changes
NullSymbolinside thecreateSafeContextfunction to ensure each context has its own uniqueNullSymbol.createSafeContextis used multiple times.Motivation and Context
The previous implementation used a shared, global
NullSymbol, which could cause conflicts between different contexts, particularly when multiple contexts were created usingcreateSafeContext. By making theNullSymbolunique per context, this change ensures better isolation, preventing potential issues and improving the overall stability of the context system.How Has This Been Tested?
Types of changes
Checklist
Further Comments