Fix config.php array error #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmetcalfe
force-pushed
the
fix-syntax
branch
from
b9c05b3 to
53c54ab
Compare
derschatta
requested changes
Nov 25, 2024
|
|
||
| // Depending on the Ngrok version its hostname is stored in different server vars | ||
| $ngrok_server_vars = array( | ||
| $_SERVER['HTTP_X_FORWARDED_HOST'] ?: '', |
There was a problem hiding this comment.
I think the easiest fix is just to change ?: to ??
There was a problem hiding this comment.
?? works for me, no additional changes needed.
Personally I prefer the array over the regex
There was a problem hiding this comment.
?? doesn't work in PHP 5.3 is the thing
There was a problem hiding this comment.
right, forgot about this dinosaur ;)
derschatta
approved these changes
Nov 25, 2024
|
|
||
| // Depending on the Ngrok version its hostname is stored in different server vars | ||
| $ngrok_server_vars = array( | ||
| $_SERVER['HTTP_X_FORWARDED_HOST'] ?: '', |
There was a problem hiding this comment.
right, forgot about this dinosaur ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was getting the following error with the example config.php syntax in PHP 8.3 - I thought I had tested it but I think mutagen wasn't syncing properly, so I was testing against an older config.php without realising
Couldn't get the
foreachloop to make sense with the?:notation, so I've just set it back to usingifstatements. I've verified that this setup works with PHP 5.3 and 8.3, and that ngrok still works.