Add warning to update message that containers will be stopped #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the irony that this small change will require people to update, therefore (potentially unknowingly) stopping their currently running containers |
|
Nice quality of life improvement 👍 Can you point this at our develop branch as per https://github.com/totara/totara-docker-dev/blob/master/CONTRIBUTING.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was not clear prior to upgrade that all running containers would be stopped.
Update to upgrade message makes this more obvious:
"There is a newer version of totara-docker-dev available. Updating will stop all running containers. Would you like to update? [Y/n] "