Skip to content

Conversation

@TadeasKriz
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Android app to support edge-to-edge display by enabling modern window insets handling and removing the deprecated Accompanist Navigation Animation library.

Key changes:

  • Enabled edge-to-edge display mode in MainActivity
  • Updated Compose Navigation library from 2.8.9 to 2.9.5
  • Removed Accompanist Navigation Animation dependency
  • Standardized parameter naming for padding values in Compose lambdas

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
android/src/main/java/co/touchlab/droidcon/android/MainActivity.kt Added enableEdgeToEdge() call to support modern window insets
shared-ui/src/androidMain/kotlin/co/touchlab/droidcon/ui/util/MainView.kt Removed systemBarsPadding() modifier to work with edge-to-edge
shared-ui/src/commonMain/kotlin/co.touchlab.droidcon/ui/BottomNavigationView.kt Renamed paddingValues to innerPadding for consistency
shared-ui/src/commonMain/kotlin/co.touchlab.droidcon/ui/session/SessionListView.kt Renamed paddingValues to innerPadding for consistency
shared-ui/src/commonMain/kotlin/co.touchlab.droidcon/ui/theme/Theme.kt Simplified when expression to if-else for two-branch condition
gradle/libs.versions.toml Updated Compose Navigation version and removed Accompanist dependency
android/build.gradle.kts Removed Accompanist implementation dependency
android/src/main/res/values/themes.xml Fixed empty XML tag formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 71 to 72
WindowCompat.setDecorFitsSystemWindows(window, false)

Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enableEdgeToEdge() call is redundant. WindowCompat.setDecorFitsSystemWindows(window, false) on line 71 already achieves the same effect as enableEdgeToEdge(). The enableEdgeToEdge() function internally calls WindowCompat.setDecorFitsSystemWindows(window, false), making one of these calls unnecessary. Consider removing line 71 and keeping only enableEdgeToEdge(), as it's the newer, more idiomatic approach.

Suggested change
WindowCompat.setDecorFitsSystemWindows(window, false)

Copilot uses AI. Check for mistakes.
@KevinSchildhorn
Copy link
Contributor

Can you provide screenshots for evidence? I don't have enough information from the PR to tell what to look for.

Copy link
Contributor

@KevinSchildhorn KevinSchildhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KevinSchildhorn
Copy link
Contributor

Screenshot_20251030_111601

@TadeasKriz TadeasKriz merged commit 14a5ae8 into main Oct 30, 2025
1 check passed
@TadeasKriz TadeasKriz deleted the tk/system-bars-fix branch October 30, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants