🐛 fix(config): set_env file| no longer overrides later values - #3740
Merged
Conversation
Values defined after a file| reference now take precedence over values loaded from the env file, matching the "last definition wins" behavior of inline set_env values. Fixes tox-dev#3335
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
set_envmixesfile|references with inline variable definitions, values from the env file always took precedence regardless of ordering. This broke the intuitive "last definition wins" rule that works correctly for purely inline definitions.🔧 The fix tracks which keys are defined after each
file|reference during parsing, then skips those keys when loading the env file. Variables only defined in the file still come through normally, while explicit inline overrides now take precedence as expected.Fixes #3335