馃悰 fix(config): keep the leading pair of a win32 UNC path - #4060
Open
MohammedAlkindi wants to merge 4 commits into
Open
馃悰 fix(config): keep the leading pair of a win32 UNC path#4060MohammedAlkindi wants to merge 4 commits into
MohammedAlkindi wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_win32_process_path_backslashcollapses any run of exactly two backslashes, treating it as the POSIX-escaped form of one literal backslash. That is right in the middle of a path, but a UNC or extended-length prefix needs both leading backslashes, so a network path incommandssilently loses one.With
commands = xcopy \\server\share\file.txt .on main:\\serverbecomes\server. No error, and the command runs against a path that does not exist.The fix keeps a backslash pair literal only when it starts a word and is followed by more path text. A bare trailing
\\is not a prefix and still collapses, which is whatWACKY_SLASH_ARGScovers; an earlier attempt that preserved every leading pair broke three of those cases.Three cases added, failing first (
assert ['\\srv\\share'] == ['\\\\srv\\share']). After:tox configreports the path intact, andtests/config/loader/test_str_convert.pyis 175 passed, 5 skipped with nothing else changing status.ruff checkandruff format --checkclean.Windows-only path, so it does not show up on Linux CI. Found by inspection, not a user report.