Register the factor label for a bare labeled dict in env_list - #4062
Open
dylanpulver wants to merge 1 commit into
Open
Register the factor label for a bare labeled dict in env_list#4062dylanpulver wants to merge 1 commit into
dylanpulver wants to merge 1 commit into
Conversation
The configuration reference states that a bare labeled dict in env_list
'also registers a {factor:label} name', but _extract_env_list_labels only
walked items carrying a 'product' key, so {factor:ecosystem} resolved to
an empty string for the bare form while the product-wrapped form resolved
it correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/reference/config.rst:130says anenv_listitem may be "a labeled dict ({ ecosystem = ["oci", "python"] }) that also registers a{factor:label}name". It does not.tox c -e oci -k description→Sync artifacts. The identical group inside aproductdict →Sync oci artifacts.Cause
_extract_env_list_labelsonly walks items with a"product"key — correct for #3865, added whenproductwas the only dict shapeenv_listtook. #3923 then taughtTomlLoader.to_env_listthree shapes and updated these docs, but never touched the source one directory over. The sibling path for[env_base.*].factorsalready registers bare groups.Fix
Register the label for a bare labeled dict too, honouring
defaultas theproductbranch does.extract_labelreturnsNonefor a range dict, so bare ranges are unaffected.Verification
Reverting the source fails both new tests; a naive variant that registers the label but drops
defaultfails the second.tests/config: 6687 passed, 2 skipped.ty,mypy,pyreflyandpre-commitclean.tox -e fix)docs/changelogfolder