Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: gen-apiが正常に走るように #343

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

reiroop
Copy link
Contributor

@reiroop reiroop commented Nov 8, 2024

PR Type

bug_fix, enhancement


Description

  • src/components/shared/InputSelectSingle.vueで、インポート文にセミコロンを追加し、ValueValue型をunknownからanyに変更しました。
  • src/components/shared/MarkdownTextarea.vueで、インポート文にセミコロンを追加し、setTemplate関数の型をanyに変更しました。
  • src/env.d.tsで、DefineComponentの型をunknownからanyに変更し、eslintのコメントを追加しました。

Changes walkthrough 📝

Relevant files
Enhancement
InputSelectSingle.vue
Adjust type definition and import formatting                         

src/components/shared/InputSelectSingle.vue

  • Added semicolons to import statements for consistency.
  • Changed ValueValue type to use any instead of unknown.
  • +4/-3     
    MarkdownTextarea.vue
    Update type usage and import formatting                                   

    src/components/shared/MarkdownTextarea.vue

  • Added semicolons to import statements for consistency.
  • Updated setTemplate function to use any type.
  • +6/-5     
    Bug fix
    env.d.ts
    Refactor type definitions with eslint adjustments               

    src/env.d.ts

  • Modified DefineComponent type to use any instead of unknown.
  • Added eslint-disable comments for type adjustments.
  • +2/-5     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    github-actions bot commented Nov 8, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Type Safety
    型定義がunknownからanyに変更されています。これにより、型安全性が低下しています。可能であれば、より具体的な型を使用することを検討してください。

    Type Safety
    setTemplate関数の引数の型がunknownからanyに変更されています。この変更は型安全性を低下させる可能性があります。より具体的な型を使用することを検討してください。

    @reiroop reiroop requested a review from anko9801 November 8, 2024 14:31
    @reiroop reiroop merged commit 5989388 into main Nov 8, 2024
    6 checks passed
    @reiroop reiroop deleted the fix/gen-api-error branch November 8, 2024 14:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants