Merge pull request #896 from traPtitech/chores/validate-env-var-name

Add env var name validation

pkg/domain/app_environment.go

@@ -1,5 +1,10 @@
 package domain
 
+import (
+	"fmt"
+	"regexp"
+)
+
 type Environment struct {
 	ApplicationID string
 	Key           string
@@ -10,3 +15,12 @@ type Environment struct {
 func (e *Environment) GetKV() (string, string) {
 	return e.Key, e.Value
 }
+
+var environmentVariableKeyFormat = regexp.MustCompile(`^[A-Z_][A-Z0-9_]*$`)
+
+func (e *Environment) Validate() error {
+	if !environmentVariableKeyFormat.MatchString(e.Key) {
+		return fmt.Errorf("bad key format: %s", e.Key)
+	}
+	return nil
+}

pkg/usecase/apiserver/app_config_service.go

@@ -25,7 +25,13 @@ func (s *Service) SetEnvironmentVariable(ctx context.Context, applicationID stri
 		return err
 	}
 
+	// Validate
 	env := &domain.Environment{ApplicationID: applicationID, Key: key, Value: value, System: false}
+	err = env.Validate()
+	if err != nil {
+		return newError(ErrorTypeBadRequest, "invalid environment variable", err)
+	}
+
 	return s.envRepo.SetEnv(ctx, env)
 }