Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FROM AS で大文字に統一 #352

Merged
merged 1 commit into from
Aug 21, 2024
Merged

FROM AS で大文字に統一 #352

merged 1 commit into from
Aug 21, 2024

Conversation

Pugma
Copy link
Collaborator

@Pugma Pugma commented Aug 21, 2024

User description

タイトルのとおりです
確認をお願いします

参考: https://docs.docker.com/reference/build-checks/from-as-casing/


PR Type

enhancement


Description

  • FROM statement in the Dockerfile updated to use uppercase AS for consistency.
  • Aligns with Docker's recommended casing practices.

Changes walkthrough 📝

Relevant files
Enhancement
Dockerfile
Standardize casing of `AS` in Dockerfile                                 

Dockerfile

  • as changed to AS for consistency.
  • Ensures uniform casing in the FROM statement.
  • +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link
    Contributor

    github-actions bot commented Aug 21, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Dockerfile のキーワードを大文字に統一して、一貫性を向上させます。

    FROM および AS の後に続くキーワードを大文字に統一することで、Dockerfile
    の可読性と一貫性を向上させることができます。node:20.11.1-alpine の部分も大文字にすることを提案します。

    Dockerfile [1]

    -FROM --platform=$BUILDPLATFORM node:20.11.1-alpine AS build
    +FROM --platform=$BUILDPLATFORM NODE:20.11.1-ALPINE AS BUILD
     
    Suggestion importance[1-10]: 3

    Why: While the suggestion to capitalize keywords can improve consistency, it is not a standard practice to capitalize image names and tags in Dockerfiles. The suggestion does not address a critical issue or bug.

    3

    @Pugma Pugma requested review from mehm8128 and sh0go07 August 21, 2024 01:13
    @Pugma Pugma enabled auto-merge August 21, 2024 01:13
    @Pugma Pugma merged commit 092396d into main Aug 21, 2024
    10 checks passed
    @Pugma Pugma deleted the upperAS branch August 21, 2024 01:48
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants