Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: removing copyright #387

Merged
merged 1 commit into from
Oct 30, 2024
Merged

revert: removing copyright #387

merged 1 commit into from
Oct 30, 2024

Conversation

Pugma
Copy link
Collaborator

@Pugma Pugma commented Oct 30, 2024

User description

コンフリクトの解消時に間違えて消してしまった部分を戻しました


PR Type

enhancement


Description

  • フッターに著作権表示を追加しました。
  • 誤って削除された部分を復元しました。

Changes walkthrough 📝

Relevant files
Enhancement
PageFooter.vue
フッターに著作権表示を追加                                                                                       

src/components/Layout/PageFooter.vue

  • フッターに著作権表示を追加
  • © 2015 traP のテキストを追加
+1/-0     

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Accessibility
画像のアクセシビリティを向上させるために alt 属性を追加する。

:class="$style.logo" に対して、alt 属性を追加して、アクセシビリティを向上させてください。

src/components/Layout/PageFooter.vue [3-6]

 <img
   src="/@/assets/traP_logo_full_white.svg"
   :class="$style.logo"
+  alt="traP Logo"
 />
Suggestion importance[1-10]: 9

Why: Adding an alt attribute to the image improves accessibility by providing a text alternative for screen readers. This is a significant enhancement for users with visual impairments, making the suggestion highly relevant and impactful.

9

Copy link

@nokhnaton nokhnaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@Pugma Pugma merged commit 7d93426 into main Oct 30, 2024
11 checks passed
@Pugma Pugma deleted the revert_removeCopyright branch October 30, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants