Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/tensor basic ops #2468

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Conversation

quinton11
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

#2450

Provide links to relevant issues and dependent PRs.

Changes

Tensor BasicOps Examples

@quinton11
Copy link
Contributor Author

@laggui @nathanielsimard

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.93%. Comparing base (69de0ef) to head (43db613).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2468      +/-   ##
==========================================
+ Coverage   82.79%   82.93%   +0.13%     
==========================================
  Files         809      811       +2     
  Lines      104191   105059     +868     
==========================================
+ Hits        86270    87135     +865     
- Misses      17921    17924       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on the examples 🙏

Just a few comments to get this started:

  • Make sure to run the tests for formatting and ensure the doc examples can compile (see CI errors)
  • I see some methods have more than one example. I think we should keep the examples succinct, so stick to one example() definition (though you could still demonstrate different manipulations when deemed relevant)

@quinton11
Copy link
Contributor Author

@laggui made the necessary changes, as well as a fix for the failing doc examples

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Made some minor changes mostly for formatting.

@laggui laggui merged commit a4567db into tracel-ai:main Nov 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants