Skip to content

cubecl-common: fix unintended std dep from web-time#1212

Open
ivila wants to merge 2 commits intotracel-ai:mainfrom
ivila:bug_unintendedStd_ivila_0304
Open

cubecl-common: fix unintended std dep from web-time#1212
ivila wants to merge 2 commits intotracel-ai:mainfrom
ivila:bug_unintendedStd_ivila_0304

Conversation

@ivila
Copy link

@ivila ivila commented Mar 4, 2026

Fixes #1211

Validate your PR with burn.

It is important that you make sure that you don't introduce any bugs in burn.

Instructions

  • Create a new branch or fork of the burn repo
  • Update the main Cargo.toml with this PR hash.
  • Fix any broken tests or compilation errors in burn.
  •  Submit a PR in burn with your fixes and link it here.

@ivila ivila changed the title Bug unintended std ivila 0304 cubecl-common: fix unintended std dep from web-time Mar 4, 2026
@ivila
Copy link
Author

ivila commented Mar 4, 2026

Burn test fails with: unresolved imports burn_backend::DeviceContext, burn_backend::DeviceState.
image

After checking, PR #1199 deleted DeviceContext and DeviceState, resulting in out-of-date references in burn.

How should I handle these errors? Should I wait for burn to be updated?

@laggui
Copy link
Member

laggui commented Mar 4, 2026

How should I handle these errors? Should I wait for burn to be updated?

Yeah we'll handle the update with Burn, the current device refactor is not complete yet.

@ivila ivila force-pushed the bug_unintendedStd_ivila_0304 branch from d903a1a to 6239ece Compare March 5, 2026 01:14
@ivila
Copy link
Author

ivila commented Mar 5, 2026

force update to fix the format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cubecl-common: web-time introduces unintended std dependency on non-wasm targets

2 participants