Skip to content

Better error handling in the tuner #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nathanielsimard wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Better error handling in the tuner #997

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2551a4b
Better error handling in the tuner
nathanielsimard Oct 28, 2025
3133f97
Merge branch 'main' into feat/better-error-handling-tuner
nathanielsimard Oct 28, 2025
8c7b799
Merge branch 'main' into feat/better-error-handling-tuner
nathanielsimard Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions crates/cubecl-runtime/src/tune/tuner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use alloc::vec::Vec;
use async_channel::{Receiver, Sender};
use cubecl_common::profile::ProfileDuration;
use hashbrown::HashSet;
use log::warn;

use core::time::Duration;

Expand Down Expand Up @@ -308,16 +309,17 @@ impl<K: AutotuneKey> Tuner<K> {
a.cmp(&b)
});

// Log & send results.
let result = results
.first()
.expect("At least one kernel needed.")
.as_ref()
.expect("At least one kernel has to succeed.");
let mut fastest_index = 0;

if let Some(result) = results.first() {
if let Ok(result) = result.as_ref() {
fastest_index = result.index;
}
}

AutotuneMessage::Done {
key,
fastest_index: result.index,
fastest_index,
results,
#[cfg(std_io)]
checksum,
Expand All @@ -341,7 +343,8 @@ impl<K: AutotuneKey> Tuner<K> {
let tunable_indices = plan.next();

if tunable_indices.is_empty() {
panic!("No autotune was flagged as valid for the problem.")
log::warn!("No autotune was flagged as valid for the problem.");
return;
}

for index in tunable_indices {
Expand Down
Loading