-
Notifications
You must be signed in to change notification settings - Fork 0
feat(terraform-service-postgres): manage pg15 backups #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…s to manage backups
☁️ Nx Cloud ReportAttention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here. CI is running/has finished running commands for commit da2cfaf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
@floross We can use pg15 now. Should we set the default postgres image tag to |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
=======================================
Coverage 73.90% 73.90%
=======================================
Files 82 82
Lines 1368 1368
Branches 252 252
=======================================
Hits 1011 1011
Misses 357 357
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We could be we need to think of the impact of the current project. If the goal is to not use terraform so much I think we should let the pg at 13 and for the new project like Fari to configure manually the version to 15. What do you think @EdouardDem ? |
POSTGRES_HOST: (service) => service.getServiceDomainName('postgres'), | ||
POSTGRES_PORT: '5432', | ||
REMOVE_OLDER_THAN: '30D', | ||
VOLUMERIZE_POSTGRES_DATABASE: 'api', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be Secret('POSTGRES_DB'),
by default ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we set it to Secret('POSTGRES_DB')
we will have to add the key POSTGRES_DB
in AWS secret manager.
@floross Once this PR is merged, for each project, we have to change the Rename the environments (the keys, not the values) :
|
change backup service to
fekide/volumerize:1.8.2-postgres