fix tr-sync-ot command #385
Open
+152
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvonessen
approved these changes
Feb 10, 2025
README.md
Outdated
Comment on lines
19
to
20
| - [tr-push](#tr-push) | ||
| - [Authentication](#authentication-2) | ||
| - [Arguments](#arguments-2) | ||
| - [Usage](#usage-3) | ||
| - [CI Integration](#ci-integration) | ||
| - [Dynamic Variables](#dynamic-variables) | ||
| - [tr-scan-packages](#tr-scan-packages) | ||
| - [Authentication](#authentication-3) |
There was a problem hiding this comment.
I think the cascading changes in this file are because the "authentication" link for #tr-push became #authentication-3 instead of -2 (and similarly with arguments and usage). I'm not sure why that would happen--is this a problem, or is it fine?
There was a problem hiding this comment.
double checking... thanks for noticing.
| logger.error( | ||
| colors.red( | ||
| `An error occurred syncing the resource ${resource} from OneTrust: ${ | ||
| debug ? err.stack : err.message |
There was a problem hiding this comment.
Does the stack include the error message? Or would you also want to print that?
There was a problem hiding this comment.
yes, it does! Good question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
levelfrom the OneTrust risk levelgetOneTrustUsermay fail to find the user. Hence,creator,respondents, andreviewersmay not get enriched with details.syncOneTrustAssessmentToTranscendso it reports error to the console instead of aborting the syncing.src/cli-sync-ot.ts.