split types into rfc6962 and staticctapi #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # internal/scti/handlers_test.go
# Conflicts: # internal/scti/handlers_test.go # Conflicts: # internal/scti/handlers_test.go
roger2hk
approved these changes
Apr 7, 2025
internal/hammer/loadtest/workers.go
Outdated
| @@ -29,7 +29,7 @@ import ( | |||
| "github.com/transparency-dev/merkle/proof" | |||
| "github.com/transparency-dev/merkle/rfc6962" | |||
| "github.com/transparency-dev/static-ct/internal/client" | |||
| "github.com/transparency-dev/static-ct/internal/types" | |||
| rfc69621 "github.com/transparency-dev/static-ct/internal/types/rfc6962" | |||
There was a problem hiding this comment.
Suggested change
| rfc69621 "github.com/transparency-dev/static-ct/internal/types/rfc6962" | |
| "github.com/transparency-dev/static-ct/internal/types/rfc6962" |
There was a problem hiding this comment.
Good catch. I can't do this because of a different import, but I sorted this out.
internal/hammer/loadtest/workers.go
Outdated
| @@ -246,7 +246,7 @@ func (w *LogWriter) Run(ctx context.Context) { | |||
|
|
|||
| // TODO: Remove the json.Unmarshal by generating the chain and | |||
| // marshaling the add chain request from w.gen() at a later stage. | |||
| var req types.AddChainRequest | |||
| var req rfc69621.AddChainRequest | |||
There was a problem hiding this comment.
Suggested change
| var req rfc69621.AddChainRequest | |
| var req rfc6962.AddChainRequest |
internal/hammer/loadtest/workers.go
Outdated
| @@ -449,7 +449,7 @@ func isPreIssuer(cert *x509.Certificate) bool { | |||
| // Look for the extension in the Extensions field and not ExtKeyUsage | |||
| // since crypto/x509 does not recognize this extension as an ExtKeyUsage. | |||
| for _, ext := range cert.Extensions { | |||
| if types.OIDExtKeyUsageCertificateTransparency.Equal(ext.Id) { | |||
| if rfc69621.OIDExtKeyUsageCertificateTransparency.Equal(ext.Id) { | |||
There was a problem hiding this comment.
Suggested change
| if rfc69621.OIDExtKeyUsageCertificateTransparency.Equal(ext.Id) { | |
| if rfc6962.OIDExtKeyUsageCertificateTransparency.Equal(ext.Id) { |
AlCutter
approved these changes
Apr 7, 2025
| @@ -12,7 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package types | |||
| package staticctapi | |||
There was a problem hiding this comment.
staticctapi is a bit "letter soupy", how about just staticct (or static-ct)?
Should be ok particularly since we're planning to rename this repo to tesseract...
There was a problem hiding this comment.
- is not recommended in Go Style Guide.
Go package names should be short and contain only lowercase letters. A package name composed of multiple words should be left unbroken in all lowercase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #198 (review)