Skip to content

Fix secret env vars export #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix secret env vars export #1994

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f9c5b8
Fix secret env vars command injection
AndriiMysko Jun 24, 2021
cdb9463
Debug
AndriiMysko Aug 3, 2021
25a4c00
Debug
AndriiMysko Aug 3, 2021
fd3ff27
Debug
AndriiMysko Aug 4, 2021
7ffb0e2
Debug
AndriiMysko Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lib/travis/build/appliances/setup_filter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def args

def exports
values = secrets.map { |value| Shellwords.escape(value) }
values = values.map.with_index { |value, ix| "export SECRET_#{ix}=#{value}" }
values = values.map.with_index { |value, ix| "export SECRET_#{ix}=#{quotize_env(value)}" }
values.join(' ')
end

Expand All @@ -120,6 +120,21 @@ def env
def info(msg, *args)
Travis::Build.logger.info(MSGS[msg] % args)
end

def quotize_env(value)
if value.include?('=')
var_name = "#{value.split('=').first}="
value = value.split('=', 2).last
else
var_name = ''
end

if (value[0] == '"' && value[-1] == '"') || (value[0] == "'" && value[-1] == "'")
"#{var_name}#{value}"
else
"#{var_name}'#{value}'"
end
end
end
end
end
Expand Down