Skip to content

Conversation

yochi66865
Copy link

No description provided.

@yochi66865 yochi66865 requested a review from a team as a code owner September 19, 2022 10:58
@yochi66865 yochi66865 changed the title update alias for field update yochi66865:add-alias-for-fields alias for field Nov 17, 2022
@yochi66865 yochi66865 changed the title update yochi66865:add-alias-for-fields alias for field update [alias](https://github.com/yochi66865/graphql-query-to-json/tree/add-alias-for-fields) for field Nov 17, 2022
@yochi66865 yochi66865 changed the title update [alias](https://github.com/yochi66865/graphql-query-to-json/tree/add-alias-for-fields) for field update alias for field Nov 17, 2022
@yochi66865 yochi66865 changed the title update alias for field update alias for field #27 Dec 28, 2022
@thomaschaplin
Copy link
Member

@yochi66865 so sorry for the delay in replying to this PR. Thank you so much for raising it - please could you add some unit tests for the changes you made?

@thomaschaplin
Copy link
Member

@yochi66865 I know this is a really old PR, but I was wondering if you could provide some context on what this is solving please?

Would be awesome to fix whatever bug it is you found!

cc @rickschubert

@rickschubert
Copy link
Contributor

rickschubert commented Aug 20, 2025

@thomaschaplin I am not entirely clear either, but I had a good look at the GitHub issue #8 . User @VincentSC mentioned on that issue (link here) that this PR could be used to support inline fragments.

I found this explanation of inline fragments online: https://www.geeksforgeeks.org/graphql/inline-fragments-in-graphql/

Example syntax:

{
  fieldName {
    ... on TypeName {
      field1
      field2
      # Additional fields specific to TypeName
    }
    ... on OtherTypeName {
      field3
      field4
      # Additional fields specific to OtherTypeName
    }
    # Additional fields common to all types
  }
}

This feature is supported by our "mirror library" json-to-graphql-query, see readme link on their project: https://github.com/vkolgi/json-to-graphql-query?tab=readme-ov-file#query-with-inline-fragments

I believe it would be good if we added a brand new issue for this, so that we can track this feature, and action it if possible.

As for the PR at hand, it seems to have been abandoned by @yochi66865 . I would vote to close this PR. (If you are reading this @yochi66865 : Thank you for using this library and for opening a pull request on this project. It is truly greatly appreciated. We will try our best to action support for this feature!)

@rickschubert
Copy link
Contributor

@thomaschaplin Can we please close this PR, see discussion above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants