Add text on Node
#41
Merged
Add text on Node
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for this! Capturing the immutable state as part of the tree formation is clever. I think that technically, text could be resolvable even if the source string is lost, via edit-range translations. I do this my own use, but it's kinda hard to for me to even decide if that would have any advantages over this mechanism. Plus, if it did, I think it could be implemented in an API-compatible way. It's possible this could also be a good path towards simplifying query predicate resolution. Though I'd have to think more on that one. But, not important for this particular change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
textproperty to the Node class.issue:#40
You can refer to this PR in the Python binding for review.