Correctly parse comments on Windows/CRLF line endings #312
+2,177
−2,185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commentwas incorrectly including the\rcharacter on file using CRLF (Windows).This change updates the regex in the
commentrule to exclude both\rand\n, changing the match pattern from/#.*/to/#[^\r\n]*/.I was not able to add a test in corpus. I tried to use the
:cstattribute with no avail so I could assert node length.Given the following file (with CRLF):
# test commentHere the previous parse value:
Now with the fix:
Command used for the output:
tree-sitter.exe parse --cst .\test.crlf.sh