Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed - long branch name overflows selected branch button #8939

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Annaseli
Copy link
Contributor

@Annaseli Annaseli commented Apr 6, 2025

Closes #8930 #8639

Change Description

Bug Fix

This PR fixes a UI issue where long branch names caused overflow in the "selected branch" button located at the top-left corner of many pages, as shown below:

image

Fix

  • Applied React Bootstrap utility classes to truncate long branch names.
  • Added a max-width to the branch button to prevent it from growing indefinitely.
  • These changes were made in refDropdown.jsx.

Additional Layout Adjustments

Updating the branch button layout caused misalignment issues with nearby buttons in the top of the page. Specifically:

  • Buttons were misaligned or pushed in different directions.
  • Buttons became too wide.
  • Text within buttons wrapped.
  • Buttons stacked vertically or appeared cramped on some pages or had no spaces between them.

To address this:

  • Updated ActionsBar and ActionGroup components in controls.jsx to use the React Bootstrap grid system.
  • Fixed styling in controls.jsx and the rest of the files to:
    • Prevent text wrapping inside buttons
    • Add proper spacing between buttons
    • Ensure consistent horizontal layout across pages
    • Pushed the buttons on the right to the right corner of the layout.
    • Fixed the misalignment
    • Prevented from the buttons become to wide.
    • Prevented Buttons stacking.

Fix:
image

Testing Details

Tested locally on lakeFS with Fluffy.

I reviewed each page that uses the ActionsBar and ActionGroup components to ensure that the style changes didn’t introduce any layout or styling issues.

@Annaseli Annaseli added area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog labels Apr 6, 2025
@Annaseli Annaseli requested a review from a team April 6, 2025 14:10
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Can you explain why you've decided to add both hover and text wrap in the path?
I would think if we decided to add a hover - any text that doesn't fit in the width will be cut

@Annaseli
Copy link
Contributor Author

Annaseli commented Apr 7, 2025

Looks great! Can you explain why you've decided to add both hover and text wrap in the path? I would think if we decided to add a hover - any text that doesn't fit in the width will be cut

@N-o-Z
I actually meant to create a separate issue for handling the long branch name in the path, since this PR was already quite large, and I forgot to mention it in the description. The original changes were focused on fixing the buttons in the top bar.

But now I've also added code to handle the long path name, so it now looks like this:
image

Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Linking an issue would have also worked@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI Improvements or additions to UI include-changelog PR description should be included in next release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: A long branch name overflows the selected branch button
3 participants