-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed - long branch name overflows selected branch button #8939
base: master
Are you sure you want to change the base?
Fixed - long branch name overflows selected branch button #8939
Conversation
…utton. In addition, added Bootstrap class styles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Can you explain why you've decided to add both hover and text wrap in the path?
I would think if we decided to add a hover - any text that doesn't fit in the width will be cut
@N-o-Z But now I've also added code to handle the long path name, so it now looks like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Linking an issue would have also worked@
Closes #8930 #8639
Change Description
Bug Fix
This PR fixes a UI issue where long branch names caused overflow in the "selected branch" button located at the top-left corner of many pages, as shown below:
Fix
refDropdown.jsx
.Additional Layout Adjustments
Updating the branch button layout caused misalignment issues with nearby buttons in the top of the page. Specifically:
To address this:
ActionsBar
andActionGroup
components incontrols.jsx
to use the React Bootstrap grid system.controls.jsx
and the rest of the files to:Fix:

Testing Details
Tested locally on lakeFS with Fluffy.
I reviewed each page that uses the ActionsBar and ActionGroup components to ensure that the style changes didn’t introduce any layout or styling issues.