Add table_def_changes function for lua unity exporter #8957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadavsteindler
added
the
include-changelog
nadavsteindler
commented
Apr 10, 2025
| @@ -201,6 +207,35 @@ local function export_delta_log(action, table_def_names, write_object, delta_cli | |||
| return response | |||
| end | |||
|
|
|||
| local function table_def_changes(table_def_names,table_descriptors_path,repository_id, source_ref, branch_id) | |||
nadavsteindler
commented
Apr 10, 2025
| error("table path is required to proceed with Delta catalog export") | ||
| end | ||
|
|
||
| --if table_path is in the diff |
There was a problem hiding this comment.
Write the actual if expression
nadavsteindler
commented
Apr 10, 2025
| @@ -34,6 +34,18 @@ local function delta_log_entry_key_generator() | |||
| end | |||
| end | |||
|
|
|||
|
|
|||
| -- Local function to get the table descriptor | |||
| local function get_table_descriptor(repo, commit_id,table_name_yaml, table_descriptors_path) | |||
There was a problem hiding this comment.
commit_id should instead be called ref since it can also be a branch name
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8292
Change Description
Create a new method in lua:
delta_exporter.table_def_changes takes a list of all table defs and returns only the ones that have changed. This dovetails well with the delta_exporter.export_delta_log function which accepts a list of tables. This way we are only exporting the tables that have actually changed.
Background
See the reported bug
Bug Fix
If this PR is a bug fix, please let us know about:
Testing Details
How were the changes tested?