fix(core): continue backup workflow even after I/O errors & timeouts#6651
Draft
fix(core): continue backup workflow even after I/O errors & timeouts#6651
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task
4d11c88 to
b46944e
Compare
b46944e to
efc2321
Compare
efc2321 to
d419aa0
Compare
c754fc8 to
374d32f
Compare
d419aa0 to
7d316d2
Compare
80f484b to
1a197d9
Compare
If `ContinueOnErrors` is active, ButtonRequest-related errors and timeouts are ignored - in order to allow the workflow to continue.
7d316d2 to
59dfbe0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




























































































































































Requires #6741.
No more button requests / errors will be sent later during the backup workflow after an I/O-related error/timeout.
Host will be ignored until the backup workflow is over - sending the final "Success" response may get fail/stuck.
TODOs: