Skip to content

fix(core): continue backup workflow even after I/O errors & timeouts#6651

Draft
romanz wants to merge 2 commits intomainfrom
romanz/ignore-host
Draft

fix(core): continue backup workflow even after I/O errors & timeouts#6651
romanz wants to merge 2 commits intomainfrom
romanz/ignore-host

Conversation

@romanz
Copy link
Copy Markdown
Contributor

@romanz romanz commented Mar 25, 2026

Requires #6741.

No more button requests / errors will be sent later during the backup workflow after an I/O-related error/timeout.

Host will be ignored until the backup workflow is over - sending the final "Success" response may get fail/stuck.

TODOs:

  • improve error test coverage

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 25, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4c7787b1-1ff7-4ace-b7aa-843dd6c121b9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch romanz/ignore-host

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@trezor-bot trezor-bot Bot added this to Firmware Mar 25, 2026
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware Mar 25, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2026

en main(all)

model device_test click_test persistence_test
T2T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all) test(all) main(all)
Translations

cs main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

de main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

es main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

fr main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

pt main(all)

model device_test click_test
T2T1 test(all) main(all) test(all) main(all)
T3B1 test(all) main(all) test(all) main(all)
T3T1 test(all) main(all) test(all) main(all)
T3W1 test(all) main(all) test(all) main(all)

Latest CI run: 25062028854

@romanz romanz force-pushed the romanz/ignore-host branch 3 times, most recently from 4d11c88 to b46944e Compare April 7, 2026 14:43
@romanz romanz moved this from 🔎 Needs review to 🏃‍♀️ In progress in Firmware Apr 23, 2026
@romanz romanz force-pushed the romanz/ignore-host branch from b46944e to efc2321 Compare April 23, 2026 19:43
@romanz romanz changed the title fix(core): continue backup workflow even after I/O errors fix(core): continue backup workflow even after I/O errors & timeouts Apr 23, 2026
@romanz romanz changed the base branch from main to romanz/2604/br-rework April 23, 2026 19:45
@romanz romanz added the translations Put this label on a PR to run tests in all languages label Apr 23, 2026
@romanz romanz force-pushed the romanz/ignore-host branch from efc2321 to d419aa0 Compare April 24, 2026 05:39
@romanz romanz force-pushed the romanz/2604/br-rework branch from c754fc8 to 374d32f Compare April 24, 2026 17:35
@romanz romanz force-pushed the romanz/ignore-host branch from d419aa0 to 7d316d2 Compare April 24, 2026 17:35
@romanz romanz force-pushed the romanz/2604/br-rework branch 2 times, most recently from 80f484b to 1a197d9 Compare April 28, 2026 13:25
Base automatically changed from romanz/2604/br-rework to main April 28, 2026 15:15
romanz added 2 commits April 28, 2026 17:17
If `ContinueOnErrors` is active, ButtonRequest-related errors and
timeouts are ignored - in order to allow the workflow to continue.
@romanz romanz force-pushed the romanz/ignore-host branch from 7d316d2 to 59dfbe0 Compare April 28, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translations Put this label on a PR to run tests in all languages

Projects

Status: 🏃‍♀️ In progress

Development

Successfully merging this pull request may close these issues.

1 participant