Clear signing definitions pipeline: 1. Firmware prerequisites by ibz · Pull Request #6748 · trezor/trezor-firmware

ibz · 2026-04-13T06:16:25Z

Follow up for #6235

Besides the existing Ethereum network and token definitions add a new one: ETHEREUM_ERC7730_DISPLAY_FORMAT.

This kind of definition is used to receive serialized ERC-7730 "display formats" - which are what the firmware needs during clear signing in order to:
1. parse and understand ERC-20 calldata
2. format calldata intent and fields in a human-readable way according to ERC-7730
This kind of definition must be signed in the same way as we sign the other kinds of definitions

Note: the protobuf serialization of DisplayFormat (EthereumERC7730DisplayFormatInfo) is meant to be future proof and support nested arrays / tuples, but the actual implementation of DisplayFormat in the clear signing code does not support that as of now.

The ability for firmware to request extra definitions during signing has been moved to a new PR (#6798) that will be merged after this, for simplicity.

github-actions · 2026-04-13T06:17:51Z

`en` main(all)

model	device_test	click_test	persistence_test
T2T1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)	test(all) main(all)

Translations

`cs` main(all)

model	device_test	click_test
T2T1	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)

`de` main(all)

model	device_test	click_test
T2T1	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)

`es` main(all)

model	device_test	click_test
T2T1	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)

`fr` main(all)

model	device_test	click_test
T2T1	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)

`pt` main(all)

model	device_test	click_test
T2T1	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)

Latest CI run: 25061585467

PrisionMike

LGTM. Just a nit and a point of clarification.

PrisionMike · 2026-04-24T06:57:50Z

+                return Array(
+                    Tuple(
+                        tuple(_get_leaf_parser(f) for f in element.tuple.fields),
+                        is_dynamic=False,  # Tuples inside Arrays are always parsed as static!


Is this an EVM thing or is it our limitation?

It's not really a limitation, but a way of parsing calldata. It's both an EVM thing and also due to our implementation. I am guessing we could have had implemented it in a way that would not require this flag to be set (depending on how we compute pointers inside containers). Can be changed any time, it's just an implementation detail of the parsing code, after all.

They are the same thing, but we are actually referring the fields by index. [no changelog]

[no changelog]

Add a callable that will be invoked on every page of the default input flow. Can be used for extra checks while confirming everything. [no changelog]

[no changelog]

Go back to having a single `token` passed with the definitions up-front like we had before e059db5. [no changelog]

[no changelog]

This comment was marked as outdated.

Sign in to view

github-actions Bot assigned ibz Apr 13, 2026

trezor-bot Bot added this to Firmware Apr 13, 2026

github-project-automation Bot moved this to 🔎 Needs review in Firmware Apr 13, 2026

ibz force-pushed the ibz/clear-signing-pipeline branch 2 times, most recently from f333dae to f7de9c2 Compare April 13, 2026 12:27

ibz changed the title ~~WIP~~ [WIP] Clear signing definitions pipeline Apr 13, 2026

ibz force-pushed the ibz/clear-signing-pipeline branch 14 times, most recently from ad41024 to b6eee2f Compare April 15, 2026 09:00

ibz changed the title ~~[WIP] Clear signing definitions pipeline~~ [WIP] Clear signing definitions pipeline (Firmware part) Apr 15, 2026

ibz force-pushed the ibz/clear-signing-pipeline branch from b6eee2f to ef5fd73 Compare April 15, 2026 09:27

ibz marked this pull request as ready for review April 15, 2026 09:28

ibz requested review from TychoVrahe, matejcik, obrusvit, prusnak and romanz as code owners April 15, 2026 09:28

ibz changed the title ~~[WIP] Clear signing definitions pipeline - Firmware part (1)~~ [WIP] Clear signing definitions pipeline: 1. Firmware prerequisites Apr 24, 2026

This was referenced Apr 24, 2026

Clear signing definitions pipeline: 2. Definitions request mechanism #6798

Draft

[WIP] Clear signing definitions pipeline: 3. Registry parser #6700

Draft

PrisionMike approved these changes Apr 24, 2026

View reviewed changes

ibz force-pushed the ibz/clear-signing-pipeline branch 4 times, most recently from 5071780 to 17a2d09 Compare April 28, 2026 10:53

ibz added the translations Put this label on a PR to run tests in all languages label Apr 28, 2026

ibz changed the title ~~[WIP] Clear signing definitions pipeline: 1. Firmware prerequisites~~ Clear signing definitions pipeline: 1. Firmware prerequisites Apr 28, 2026

ibz force-pushed the ibz/clear-signing-pipeline branch from 347bce5 to 17a2d09 Compare April 28, 2026 14:43

ibz added 13 commits April 28, 2026 18:17

chore(ethereum): rename Struct to Tuple

6e6cbfd

They are the same thing, but we are actually referring the fields by index. [no changelog]

refactor(ethereum): reuse confirmation code

3a173d3

[no changelog]

chore(ethereum): add more parsers

750f69a

[no changelog]

feat(ethereum): display format definitions

e059db5

[no changelog]

feat(tests,ethereum): clear signing definitions

e0ff0e7

[no changelog]

feat(tests): check every page of the default flow

33267e0

Add a callable that will be invoked on every page of the default input flow. Can be used for extra checks while confirming everything. [no changelog]

feat(tests,ethereum): add clear signing assertions

4d41b6e

[no changelog]

chore(ethereum): skip clear signing for large data

7503157

[no changelog]

chore(tests,ethereum): include token payload cases

b7f2134

[no changelog]

chore(tests,ethereum): multiple tokens decoding

a8af60b

[no changelog]

chore(ethereum): remove unused container paths

48e594a

[no changelog]

chore(ethereum): revert to single token up-front

de183e5

Go back to having a single `token` passed with the definitions up-front like we had before e059db5. [no changelog]

chore: update fixtures

d350121

[no changelog]

ibz force-pushed the ibz/clear-signing-pipeline branch from 17a2d09 to d350121 Compare April 28, 2026 15:19

ibz merged commit 46540d8 into main Apr 28, 2026
166 checks passed

ibz deleted the ibz/clear-signing-pipeline branch April 28, 2026 15:57

trezor-bot Bot moved this from 🔎 Needs review to 🤝 Needs QA in Firmware Apr 28, 2026

ibz moved this from 🤝 Needs QA to ✅ Done (no QA) in Firmware Apr 29, 2026

ibz mentioned this pull request Apr 29, 2026

Cleanup ERC-7730 type names #6848

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Clear signing definitions pipeline: 1. Firmware prerequisites#6748

Clear signing definitions pipeline: 1. Firmware prerequisites#6748
ibz merged 13 commits intomainfrom
ibz/clear-signing-pipeline

ibz commented Apr 13, 2026 •

edited

Loading

Uh oh!

This comment was marked as outdated.

github-actions Bot commented Apr 13, 2026 •

edited

Loading

`cs` main(all)

`de` main(all)

`es` main(all)

`fr` main(all)

`pt` main(all)

Uh oh!

PrisionMike left a comment

Uh oh!

Uh oh!

PrisionMike Apr 24, 2026

Uh oh!

ibz Apr 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ibz commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

github-actions Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

en main(all)

cs main(all)

de main(all)

es main(all)

fr main(all)

pt main(all)

Uh oh!

PrisionMike left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PrisionMike Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

ibz Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ibz commented Apr 13, 2026 •

edited

Loading

github-actions Bot commented Apr 13, 2026 •

edited

Loading

`en` main(all)

`cs` main(all)

`de` main(all)

`es` main(all)

`fr` main(all)

`pt` main(all)