chore(vendor): update ts-tvl to version 2.4

[M1nd3r]

• Updates ts-tvl submodule to version 2.4.
• Release notes: https://github.com/tropicsquare/ts-tvl/releases/tag/2.4
• Follows Update ts-tvl and cryptography #6561, where ts-tvl was pinned to a non-release commit to enable support for cryptography >=43.

Also, the tropic model config was adjusted:

• Uses string representation instead of bytes for riscv_fw_version.
• Specifies spect_fw_version to 1.0.0, which would otherwise be set to a different default value (1.2.0).

[coderabbitai]

Walkthrough

The PR updates the vendor/ts-tvl git submodule pointer to a new commit. The script core/tools/generate_tropic_model_config.py was changed to stop deriving firmware version bytes from numeric RISCV_FW_* constants and now emits the literal string "1.0.0" for riscv_fw_version and adds a new spect_fw_version field set to "1.0.0"; related version-byte assembly logic and constants were removed. The tests/tropic_model/config.yml file was updated to use a plain 1.0.0 string for riscv_fw_version and to include the new spect_fw_version: 1.0.0.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	The PR description lacks required structural elements from the template, such as PR setup, development status, and post-merge status information for core developers.	Complete the PR description by addressing the template sections: assign the PR, add to project, set priority/team/sprint, update development status, and add post-merge status with QA notes if applicable.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: updating the ts-tvl vendor submodule to version 2.4, which is the primary focus of the PR.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch m1nd3r/ts-tsvl-2.4

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

en main(all)

model	device_test	click_test	persistence_test
T2T1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3B1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3T1	test(all) main(all)	test(all) main(all)	test(all) main(all)
T3W1	test(all) main(all)	test(all) main(all)	test(all) main(all)

Latest CI run: 25057489308

[coderabbitai]

🧹 Nitpick comments (1)

core/tools/generate_tropic_model_config.py (1)

109-110: Avoid duplicating the firmware version literal.

Consider extracting "1.0.0" into one constant to prevent accidental drift between riscv_fw_version and spect_fw_version.

♻️ Suggested refactor

@@
 EXTRA_FILES = [
@@
 ]
+
+FW_VERSION = "1.0.0"
@@
-        "riscv_fw_version": "1.0.0",  # Version of the RISCV Firmware (also know as Application FW) used in TS7 devices
-        "spect_fw_version": "1.0.0",
+        "riscv_fw_version": FW_VERSION,  # Version of the RISCV Firmware (also know as Application FW) used in TS7 devices
+        "spect_fw_version": FW_VERSION,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@core/tools/generate_tropic_model_config.py` around lines 109 - 110, The two
firmware version literals for "riscv_fw_version" and "spect_fw_version" are
duplicated; introduce a single constant (e.g., FW_VERSION or DEFAULT_FW_VERSION)
at the top of generate_tropic_model_config.py and use that constant for both
"riscv_fw_version" and "spect_fw_version" so they cannot drift independently;
update any surrounding comments or variable references to use the new constant
and ensure the constant is the single source of truth for firmware version.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@core/tools/generate_tropic_model_config.py`:
- Around line 109-110: The two firmware version literals for "riscv_fw_version"
and "spect_fw_version" are duplicated; introduce a single constant (e.g.,
FW_VERSION or DEFAULT_FW_VERSION) at the top of generate_tropic_model_config.py
and use that constant for both "riscv_fw_version" and "spect_fw_version" so they
cannot drift independently; update any surrounding comments or variable
references to use the new constant and ensure the constant is the single source
of truth for firmware version.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b1c2c69a-bc1a-459f-885f-8a8f95120193

📥 Commits

Reviewing files that changed from the base of the PR and between 730eea4 and 2c11fe8.

📒 Files selected for processing (2)

• core/tools/generate_tropic_model_config.py
• tests/tropic_model/config.yml